chore: First integration tests for Hue #1541
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 61 files 378 suites 0s ⏱️ Results for commit e47e0e8. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e47e0e8 |
greens
reviewed
Jul 24, 2024
The next Lua Libs API release will have rudimentary support for testing LAN type edge drivers, so we're starting to write some integration tests for Philips Hue in advance of this. The current state of the in-development Lua Libs supports basic TCP client/server REST-ful interactions, so we've started writing some tests to exercise that.
dkjson will return a numerical value in the 2nd return position on success, whereas the on-hub json decode only uses that for errors. So places where we check for the presence of an error without checking for a nil first return will be false positives.
dljsjr
force-pushed
the
chore/philips-hue-integration-tests
branch
from
c481a86 to
f60dc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
The next Lua Libs API release will have rudimentary support for testing LAN type edge drivers, so we're starting to write some integration tests for Philips Hue in advance of this.
The current state of the in-development Lua Libs supports basic TCP client/server REST-ful interactions, so we've started writing some tests to exercise that.
Summary of Completed Tests
WIP