formating

src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

@@ -425,8 +425,8 @@ public SlimefunBlockData getBlockData(Location l) {
             return getBlockDataFromCache(l);
         }
 
-        //var chunk = l.getChunk();
-        //fix issue #935
+        // var chunk = l.getChunk();
+        // fix issue #935
         var chunkData = getChunkDataCache(l, false);
         var lKey = LocationUtils.getLocKey(l);
         if (chunkData != null) {
@@ -444,7 +444,7 @@ public SlimefunBlockData getBlockData(Location l) {
         var re =
                 result.isEmpty() ? null : new SlimefunBlockData(l, result.get(0).get(FieldKey.SLIMEFUN_ID));
         if (re != null) {
-            //fix issue #935
+            // fix issue #935
             chunkData = getChunkDataCache(l, true);
             chunkData.addBlockCacheInternal(re, false);
             re = chunkData.getBlockCacheInternal(lKey);
@@ -1272,14 +1272,15 @@ private SlimefunChunkData getChunkDataCache(Chunk chunk, boolean createOnNotExis
                 })
                 : loadedChunk.get(LocationUtils.getChunkKey(chunk));
     }
-    //fix issue 935: auto chunk load when using loc.getChunk(),if chunk data is already loaded into cache, we generate keyString using location,instead of loc.getChunk
+    // fix issue 935: auto chunk load when using loc.getChunk(),if chunk data is already loaded into cache, we generate
+    // keyString using location,instead of loc.getChunk
     private SlimefunChunkData getChunkDataCache(Location loc, boolean createOnNotExists) {
-        var re= loadedChunk.get(LocationUtils.getChunkKey(loc));
-        if(re!=null){
+        var re = loadedChunk.get(LocationUtils.getChunkKey(loc));
+        if (re != null) {
             return re;
-        }else{
-            //这里不要检测createOnNotExist 容易出事
-            return getChunkDataCache(loc.getChunk(),createOnNotExists);
+        } else {
+            // jump to origin getChunkDataCache and call getChunk() to trigger chunkLoad
+            return getChunkDataCache(loc.getChunk(), createOnNotExists);
         }
     }
 

src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/util/LocationUtils.java

@@ -28,8 +28,9 @@ public static String getLocKey(Location l) {
     public static String getChunkKey(Chunk chunk) {
         return chunk.getWorld().getName() + ";" + chunk.getX() + ":" + chunk.getZ();
     }
+
     public static String getChunkKey(Location loc) {
-        return loc.getWorld().getName() + ";" + (loc.getBlockX()>>4) + ":" + (loc.getBlockZ()>>4);
+        return loc.getWorld().getName() + ";" + (loc.getBlockX() >> 4) + ":" + (loc.getBlockZ() >> 4);
     }
 
     public static Location toLocation(String lKey) {

src/main/java/io/github/thebusybiscuit/slimefun4/api/items/SlimefunItemStack.java

@@ -55,11 +55,11 @@ public SlimefunItemStack(@Nonnull String id, @Nonnull ItemStack item) {
 
         Validate.notNull(id, "The Item id must never be null!");
         Validate.isTrue(
-            id.equals(id.toUpperCase(Locale.ROOT)), "Slimefun Item Ids must be uppercase! (e.g. 'MY_ITEM_ID')");
+                id.equals(id.toUpperCase(Locale.ROOT)), "Slimefun Item Ids must be uppercase! (e.g. 'MY_ITEM_ID')");
 
         if (Slimefun.instance() == null) {
             throw new PrematureCodeException(
-                "A SlimefunItemStack must never be be created before your Plugin was enabled.");
+                    "A SlimefunItemStack must never be be created before your Plugin was enabled.");
         }
 
         this.id = id;
@@ -85,7 +85,7 @@ public SlimefunItemStack(@Nonnull String id, @Nonnull Material type, @Nonnull Co
     }
 
     public SlimefunItemStack(
-        @Nonnull String id, @Nonnull Material type, @Nullable String name, @Nonnull Consumer<ItemMeta> consumer) {
+            @Nonnull String id, @Nonnull Material type, @Nullable String name, @Nonnull Consumer<ItemMeta> consumer) {
         this(id, type, meta -> {
             if (name != null) {
                 meta.setDisplayName(ChatColor.translateAlternateColorCodes('&', name));
@@ -117,7 +117,7 @@ public SlimefunItemStack(@Nonnull String id, @Nonnull Material type, @Nullable S
     }
 
     public SlimefunItemStack(
-        @Nonnull String id, @Nonnull Material type, @Nonnull Color color, @Nullable String name, String... lore) {
+            @Nonnull String id, @Nonnull Material type, @Nonnull Color color, @Nullable String name, String... lore) {
         this(id, type, im -> {
             if (name != null) {
                 im.setDisplayName(ChatColor.translateAlternateColorCodes('&', name));
@@ -144,11 +144,11 @@ public SlimefunItemStack(
     }
 
     public SlimefunItemStack(
-        @Nonnull String id,
-        @Nonnull Color color,
-        @Nonnull PotionEffect effect,
-        @Nullable String name,
-        String... lore) {
+            @Nonnull String id,
+            @Nonnull Color color,
+            @Nonnull PotionEffect effect,
+            @Nullable String name,
+            String... lore) {
         this(id, Material.POTION, im -> {
             if (name != null) {
                 im.setDisplayName(ChatColor.translateAlternateColorCodes('&', name));
@@ -190,7 +190,7 @@ public SlimefunItemStack(@Nonnull String id, @Nonnull HeadTexture head, @Nullabl
     }
 
     public SlimefunItemStack(
-        @Nonnull String id, @Nonnull String texture, @Nullable String name, @Nonnull Consumer<ItemMeta> consumer) {
+            @Nonnull String id, @Nonnull String texture, @Nullable String name, @Nonnull Consumer<ItemMeta> consumer) {
         this(id, getSkull(id, texture), meta -> {
             if (name != null) {
                 meta.setDisplayName(ChatColor.translateAlternateColorCodes('&', name));
@@ -309,11 +309,11 @@ public void lock() {
             return texture;
         } else if (CommonPatterns.HEXADECIMAL.matcher(texture).matches()) {
             String value =
-                "{\"textures\":{\"SKIN\":{\"url\":\"http://textures.minecraft.net/texture/" + texture + "\"}}}";
+                    "{\"textures\":{\"SKIN\":{\"url\":\"http://textures.minecraft.net/texture/" + texture + "\"}}}";
             return Base64.getEncoder().encodeToString(value.getBytes(StandardCharsets.UTF_8));
         } else {
             throw new IllegalArgumentException(
-                "The provided texture for Item \"" + id + "\" does not seem to be a valid texture String!");
+                    "The provided texture for Item \"" + id + "\" does not seem to be a valid texture String!");
         }
     }
 

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/blocks/AbstractMonsterSpawner.java

@@ -14,7 +14,6 @@
 import javax.annotation.ParametersAreNonnullByDefault;
 import org.apache.commons.lang.Validate;
 import org.bukkit.ChatColor;
-import org.bukkit.block.Block;
 import org.bukkit.block.BlockState;
 import org.bukkit.block.CreatureSpawner;
 import org.bukkit.entity.EntityType;
@@ -68,11 +67,10 @@ public Optional<EntityType> getEntityType(@Nonnull ItemStack item) {
                 return Optional.of(type);
             }
         }
-        if(meta instanceof BlockStateMeta blockStateMeta){
-            if(blockStateMeta.hasBlockState()&& blockStateMeta.getBlockState() instanceof CreatureSpawner spawner){
-                EntityType type=spawner.getSpawnedType();
-                if(type!=null)
-                    return Optional.of(type);
+        if (meta instanceof BlockStateMeta blockStateMeta) {
+            if (blockStateMeta.hasBlockState() && blockStateMeta.getBlockState() instanceof CreatureSpawner spawner) {
+                EntityType type = spawner.getSpawnedType();
+                if (type != null) return Optional.of(type);
             }
         }
 
@@ -91,12 +89,12 @@ public Optional<EntityType> getEntityType(@Nonnull ItemStack item) {
      */
     @Nonnull
     public ItemStack getItemForEntityType(@Nullable EntityType type) {
-        //Validate.notNull(type, "The EntityType cannot be null");
+        // Validate.notNull(type, "The EntityType cannot be null");
 
         ItemStack item = getItem().clone();
         ItemMeta meta = item.getItemMeta();
-        //fix: you can't set null type or a not-spawnable type, for example ,player
-        if(type!=null&&type.isSpawnable()) {
+        // fix: you can't set null type or a not-spawnable type, for example ,player
+        if (type != null && type.isSpawnable()) {
 
             // Fixes #2583 - Proper NBT handling of Spawners
             if (meta instanceof BlockStateMeta stateMeta) {
@@ -115,7 +113,7 @@ public ItemStack getItemForEntityType(@Nullable EntityType type) {
         for (int i = 0; i < lore.size(); i++) {
             String currentLine = lore.get(i);
             if (currentLine.contains("<Type>") || currentLine.contains("<类型>")) {
-                String typeName = type==null?"空" :ChatUtils.humanize(type.name());
+                String typeName = type == null ? "空" : ChatUtils.humanize(type.name());
                 lore.set(i, currentLine.replace("<Type>", typeName).replace("<类型>", typeName));
                 break;
             }
@@ -125,16 +123,19 @@ public ItemStack getItemForEntityType(@Nullable EntityType type) {
         item.setItemMeta(meta);
         return item;
     }
-    //to fix the bug of stacking two BROKEN_SPAWNER/REINFORCED_SPAWNER containing different EntityType using cargo or machine
-    public boolean canStack(@Nonnull ItemMeta itemMetaOne, @Nonnull ItemMeta itemMetaTwo){
-        if(itemMetaOne instanceof BlockStateMeta blockStateMeta1&& itemMetaTwo instanceof BlockStateMeta blockStateMeta2){
-            if(blockStateMeta1.hasBlockState()&&blockStateMeta2.hasBlockState()){
-                //BlockState.equals do not compare these data
-                if(blockStateMeta1.getBlockState() instanceof CreatureSpawner spawner1&& blockStateMeta2.getBlockState() instanceof CreatureSpawner spawner2){
-                    return spawner1.getSpawnedType()==spawner2.getSpawnedType();
+    // to fix the bug of stacking two BROKEN_SPAWNER/REINFORCED_SPAWNER containing different EntityType using cargo or
+    // machine
+    public boolean canStack(@Nonnull ItemMeta itemMetaOne, @Nonnull ItemMeta itemMetaTwo) {
+        if (itemMetaOne instanceof BlockStateMeta blockStateMeta1
+                && itemMetaTwo instanceof BlockStateMeta blockStateMeta2) {
+            if (blockStateMeta1.hasBlockState() && blockStateMeta2.hasBlockState()) {
+                // BlockState.equals do not compare these data
+                if (blockStateMeta1.getBlockState() instanceof CreatureSpawner spawner1
+                        && blockStateMeta2.getBlockState() instanceof CreatureSpawner spawner2) {
+                    return spawner1.getSpawnedType() == spawner2.getSpawnedType();
                 }
-            }else{
-                return blockStateMeta1.hasBlockState()==blockStateMeta2.hasBlockState();
+            } else {
+                return blockStateMeta1.hasBlockState() == blockStateMeta2.hasBlockState();
             }
         }
         return false;

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/tools/PickaxeOfContainment.java

@@ -51,7 +51,7 @@ public PickaxeOfContainment(
 
             if (b.getType() == Material.SPAWNER) {
                 ItemStack spawner = breakSpawner(b);
-                if(spawner!=null){
+                if (spawner != null) {
                     SlimefunUtils.spawnItem(
                             b.getLocation(), spawner, ItemSpawnReason.BROKEN_SPAWNER_DROP, true, e.getPlayer());
 
@@ -69,13 +69,13 @@ public PickaxeOfContainment(
         If the spawner's BlockStorage has BlockInfo, then it's not a vanilla spawner
         and should not give a broken spawner but a repaired one instead.
         */
-        SlimefunItem item=StorageCacheUtils.getSfItem(b.getLocation());
+        SlimefunItem item = StorageCacheUtils.getSfItem(b.getLocation());
         if (item instanceof RepairedSpawner) {
             spawner = (AbstractMonsterSpawner) SlimefunItems.REPAIRED_SPAWNER.getItem();
-        } else if (item ==null) {
+        } else if (item == null) {
             spawner = (AbstractMonsterSpawner) SlimefunItems.BROKEN_SPAWNER.getItem();
-        }else{
-            //do not drop anything when mining other addon's spawner-material machine
+        } else {
+            // do not drop anything when mining other addon's spawner-material machine
             return null;
         }
 

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/tools/SmeltersPickaxe.java

@@ -45,7 +45,7 @@ public SmeltersPickaxe(ItemGroup itemGroup, SlimefunItemStack item, RecipeType r
                         drops.add(drop);
                     }
                 }
-                //fix issue #967
+                // fix issue #967
                 e.setDropItems(false);
                 damageItem(e.getPlayer(), tool);
             }

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BackpackListener.java

@@ -10,12 +10,9 @@
 import io.github.thebusybiscuit.slimefun4.implementation.items.backpacks.Cooler;
 import io.github.thebusybiscuit.slimefun4.implementation.items.backpacks.SlimefunBackpack;
 import java.util.HashMap;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.UUID;
-import java.util.concurrent.ThreadLocalRandom;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import javax.annotation.ParametersAreNonnullByDefault;
@@ -208,7 +205,7 @@ private void openBackpack(Player p, ItemStack item, PlayerProfile profile, int s
             PlayerBackpack.getAsync(
                     item,
                     backpack -> {
-                        //fix the issue #978 dupe with fast-click backpack
+                        // fix the issue #978 dupe with fast-click backpack
                         backpack.open(p);
                         backpacks.put(p.getUniqueId(), item);
                         invSnapshot.put(

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/SoulboundListener.java

@@ -45,16 +45,15 @@ public void onDamage(PlayerDeathEvent e) {
         }
 
         // There shouldn't even be any items in there, but let's be extra safe!
-//        Map<Integer, ItemStack> existingItems = soulbound.get(p.getUniqueId());
-        //fix issue #964 dupe using soulbound
-//
-//        if (existingItems == null) {
-//        } else {
-//            existingItems.putAll(items);
-//        }
+        //        Map<Integer, ItemStack> existingItems = soulbound.get(p.getUniqueId());
+        // fix issue #964 dupe using soulbound
+        //
+        //        if (existingItems == null) {
+        //        } else {
+        //            existingItems.putAll(items);
+        //        }
         soulbound.put(p.getUniqueId(), items);
 
-
         // Remove soulbound items from our drops
         e.getDrops().removeIf(itemStack -> SlimefunUtils.isSoulbound(itemStack, p.getWorld()));
     }

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/crafting/AnvilListener.java

@@ -39,10 +39,12 @@ public void onAnvil(InventoryClickEvent e) {
             }
         }
     }
+
     @EventHandler(ignoreCancelled = true)
-    public void onAnvilCraft(PrepareAnvilEvent e){
-        //fix issue #958
-        if(e.getInventory().getType() == InventoryType.ANVIL&&e.getInventory().getSize()>=2){
+    public void onAnvilCraft(PrepareAnvilEvent e) {
+        // fix issue #958
+        if (e.getInventory().getType() == InventoryType.ANVIL
+                && e.getInventory().getSize() >= 2) {
             ItemStack item1 = e.getInventory().getContents()[0];
             ItemStack item2 = e.getInventory().getContents()[1];
             if (hasUnallowedItems(item1, item2)) {

src/main/java/io/github/thebusybiscuit/slimefun4/utils/SlimefunUtils.java

@@ -328,8 +328,8 @@ public static boolean isItemSimilar(
                 String id = Slimefun.getItemDataService().getItemData(itemMeta).orElse(null);
 
                 if (id != null) {
-                    //to fix issue #976
-                    if(id.equals(sfItemStack.getItemId())) {
+                    // to fix issue #976
+                    if (id.equals(sfItemStack.getItemId())) {
                         if (checkDistinctiveItem) {
                             /*
                              * PR #3417
@@ -373,9 +373,9 @@ public static boolean isItemSimilar(
                      * Some items can't rely on just IDs matching and will implement Distinctive Item
                      * in which case we want to use the method provided to compare
                      */
-                    //to fix issue #976
+                    // to fix issue #976
                     var match = id.equals(possibleItemId);
-                    if(match) {
+                    if (match) {
                         Optional<DistinctiveItem> optionalDistinctive = getDistinctiveItem(id);
                         if (optionalDistinctive.isPresent()) {
                             return optionalDistinctive.get().canStack(possibleSfItemMeta, itemMeta);