Added the option to disable the Per World Configuration file generation + a fast way to disabled the worlds #2985
Conversation
New 2 options: 1) Disable per world config file generation; 2) Disable worlds in a fast way;
There was a problem hiding this comment.
Just a heads up:
We are currently quite busy and there are 12 other Pull Requests in this repository alone.
This isn't high up on our priority list at the moment, so it will still take a while until we get to reviewing this pull request.
We will also still need to debate about this internally about potential side effects that may come from such a change.
TheBusyBot
added
the
⚡ Merge Conflicts
TheBusyBot
removed
the
⚡ Merge Conflicts
| config.getConfiguration().options().header("This file is used to disable certain items in a particular world.\nYou can set any item to 'false' to disable it in the world '" + name + "'.\nYou can also disable an entire addon from Slimefun by setting the respective\nvalue of 'enabled' for that Addon.\n\nItems which are disabled in this world will not show up in the Slimefun Guide.\nYou won't be able to use these items either. Using them will result in a warning message."); | ||
| config.getConfiguration().options().copyHeader(true); | ||
| config.setDefaultValue("enabled", true); | ||
| if (!SlimefunPlugin.getCfg().getBoolean("options.disable-per-world-config")) { |
There was a problem hiding this comment.
There is no need to read this boolean everytime a World is loaded.
The value should probably be stored as a field and read via the load() method.
| disabled-worlds: | ||
| - 'THIS_WORLD_IS_DISABLED' |
There was a problem hiding this comment.
I am not a big fan of the disabled-worlds list right here as it is kinda redundant with what World Settings try to achieve which is not really comfortable.
There was a problem hiding this comment.
I put it there in case some one decides not to use the base system, where the world file is no longer present
TheBusyBot
added
the
⚡ Merge Conflicts
|
Closing this as stale |
Description
I have implemented an option to disable the creation of files (therefore the management of items) of each world, in order to avoid large quantities in case you have more worlds ... I have also implemented a blacklist of the worlds (in order to fill the gap of these files)
Proposed changes
The idea is to avoid the increase of files in the folder in case of server based on multi world (SkyBlock type with SlimeWorldManager)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values