Stopped 'Slimefun' Infernal Dust dropping #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sefiraat
changed the title
TheBusyBiscuit
requested changes
Jul 5, 2021
src/main/java/io/github/thebusybiscuit/sensibletoolbox/slimefun/SlimefunBridge.java
Outdated
Show resolved
Hide resolved
TheBusyBiscuit
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Infernal Dust drops two different stack types, one from STB's Drop and another from the MobDrop recipe type in Slimefun. The Slimefun drop includes Slimefun data making the two items not stack. This also inflates the drop rate beyond what is intended within STB.
Changes
Created a new 'dummy' recipe type to look the same as Slimefun's MobDrop recipe type for display on the guide without triggering Slimefun's drops.
Related Issues
Resolves #74
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values