Updated all namings to new the one#26
Updated all namings to new the one#26TheBusyBiscuit merged 1 commit intoSlimefun:rc-27from variananora:rc-27-update
Conversation
TheBusyBiscuit
left a comment
There was a problem hiding this comment.
ooof, now we have a problem. Yeah, this will certainly break metrics on older versions :/
The entire reason why this module exists is too remain version-independent, so that's kinda a deal-breaker...
@WalshyDev any idea on how to tackle this?
|
Not easily :/ There could be some reflection thing and we have a getInstance (which returns Slimefun.getInstance or SlimefunPlugin.getInstance) but, this will add a little bit to the startup time. Not crazy but a bit slower and just makes it more awkward :/ Edit: Actually that wouldn't even work still... No idea honestly. It's gonna be a pain |
|
@WalshyDev What if we make a new repo, e.g. |
|
God that's awkward but yeah, it'll work |
|
Well, archive this one and call it a day, that's what happens to many projects here :LUL: |
Running the RC-27 will gave you some error because of the old package location.
This will hopefully fixed that.