Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Updated all namings to new the one#26

Merged
TheBusyBiscuit merged 1 commit intoSlimefun:rc-27from
variananora:rc-27-update
Sep 6, 2021
Merged

Updated all namings to new the one#26
TheBusyBiscuit merged 1 commit intoSlimefun:rc-27from
variananora:rc-27-update

Conversation

@variananora
Copy link
Member

Running the RC-27 will gave you some error because of the old package location.

This will hopefully fixed that.

Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooof, now we have a problem. Yeah, this will certainly break metrics on older versions :/
The entire reason why this module exists is too remain version-independent, so that's kinda a deal-breaker...

@WalshyDev any idea on how to tackle this?

@WalshyDev
Copy link
Member

WalshyDev commented Sep 6, 2021

Not easily :/

There could be some reflection thing and we have a getInstance (which returns Slimefun.getInstance or SlimefunPlugin.getInstance) but, this will add a little bit to the startup time. Not crazy but a bit slower and just makes it more awkward :/

Edit: Actually that wouldn't even work still... No idea honestly. It's gonna be a pain

@TheBusyBiscuit TheBusyBiscuit changed the base branch from master to rc-27 September 6, 2021 09:52
@TheBusyBiscuit TheBusyBiscuit merged commit 1b6223f into Slimefun:rc-27 Sep 6, 2021
@TheBusyBiscuit
Copy link
Member

@WalshyDev What if we make a new repo, e.g. MetricsModule2?
Slimefun will then ping that one for updates, whereas older versions will still ping this repo.

@WalshyDev
Copy link
Member

God that's awkward but yeah, it'll work

@TheBusyBiscuit
Copy link
Member

Well, archive this one and call it a day, that's what happens to many projects here :LUL:

@variananora variananora deleted the rc-27-update branch September 6, 2021 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants