Skip to content

ENH: Update extension metadata #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Apr 22, 2024

Consolidate extension metadata based on the corresponding s4ext file organized in the ExtensionsIndex repository.

@jcfr
Copy link
Contributor Author

jcfr commented May 14, 2024

Ping @ljod @jhlegarreta @pieper @zhangfanmark

After addressing:

... it would be great if this could be updated & integrated 🙏

@pieper
Copy link
Contributor

pieper commented May 14, 2024

Thanks for the ping @jcfr - I believe the old SlicerWMA was the actually slicer extension, while whitematteranalysis was the repo with more general non-slicer functionality, so changing the URL like this doesn't look right.

@zhangfanmark was working on the new extension here: https://github.com/SlicerDMRI/SlicerTractParcellation

This is the work in progress for the new extension: Slicer/ExtensionsIndex#2037

Maybe we should remove the old extension index entry until the new extension is ready?

Consolidate extension metadata based on the corresponding s4ext file organized
in the ExtensionsIndex repository.
@jcfr jcfr force-pushed the update-extension-metadata branch from 8684383 to 2acb27a Compare May 14, 2024 22:01
@jcfr
Copy link
Contributor Author

jcfr commented May 14, 2024

Ditto. The file has been fixed. I then suggest to rename SlicerWMA-OLD back to SlicerWMA and archive it as detailed in #11

Once SlicerTractParcellation is ready, we will then also archive1 the SlicerWMA extension.

Footnotes

  1. https://github.com/Slicer/ExtensionsIndex/tree/main/ARCHIVE#archive

@jcfr
Copy link
Contributor Author

jcfr commented Jun 4, 2024

Please, could this be approved & merged 🙏

The changes are only related to using https instead of http, and removing the use of an invalid screenshot URL.

cc: @ljod @jhlegarreta @pieper @zhangfanmark

Copy link
Contributor

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcfr 👍

@pieper pieper merged commit c173e95 into SlicerDMRI:master Jun 4, 2024
@jcfr jcfr deleted the update-extension-metadata branch June 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants