Skip to content

Conversation

@hjmjohnson
Copy link
Member

Modernize the generateCLP main code, and generated code.

Updating the generated code allows programs using
SEM to build cleanly with clang-tidy.

@hjmjohnson hjmjohnson requested review from jcfr and lassoan August 7, 2021 01:55
@hjmjohnson hjmjohnson self-assigned this Aug 7, 2021
@hjmjohnson
Copy link
Member Author

@jcfr Do you have concerns with the change proposed? These changes clear at least 6 warnings for every executable that uses SEM PARSE_ARGS at the begining of the main function.

@jcfr
Copy link
Member

jcfr commented Aug 13, 2021

Thanks for the reminder and for working on this 🙏 💯

Since the minimum version of C++ standard now supported is 11, the proposed changes make sense.

set(VALID_CXX_STANDARDS "11" "14" "17")

Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address #136 before merging

hjmjohnson and others added 2 commits February 25, 2022 17:09
Modernize the generateCLP main code, and generated code.

Updating the generated code allows programs using
SEM to build cleanly with clang-tidy.
@hjmjohnson hjmjohnson force-pushed the clang-format-cleanups branch from 30b7435 to 86d9ed4 Compare February 25, 2022 23:10
@hjmjohnson
Copy link
Member Author

@jcfr Can this now be merged? It has been open without substantive changes or concerns since the last august.

@hjmjohnson
Copy link
Member Author

@jcfr PING.

@hjmjohnson
Copy link
Member Author

@jcfr #136 was holding this up, but is now closed. Can we please merge this PR now?

@hjmjohnson
Copy link
Member Author

@jcfr @pieper Any chance that this can be rejected or accepted? It has been passing for nearly a year.

@jcfr
Copy link
Member

jcfr commented Jul 19, 2022

Thanks for the ping 🙏 Will follow up on this 🚀

@hjmjohnson
Copy link
Member Author

ping.. silent little ping.. barely audible.

@jamesobutler
Copy link
Contributor

jamesobutler commented Feb 15, 2023

@hjmjohnson Are there any additional changes you would like to make here considering Slicer defined the minimum to C++17 since you last pushed changes here. Slicer/Slicer@dedb6c0

@hjmjohnson
Copy link
Member Author

@jamesobutler Perhaps, but I don't want to hold this PR up any longer. It has been 18 months waiting for this step to be approved. I don't want to put any more effort into making this better until I know that previous efforts are considered. I don't know if this PR is rejected.

@jcfr
Copy link
Member

jcfr commented Feb 23, 2023

Thanks for the reminder 🙏 and patience.

Will integrate today 🚀

@jamesobutler jamesobutler requested a review from jcfr March 1, 2023 01:51
@jcfr jcfr merged commit bd2efa9 into master Mar 18, 2023
@jcfr jcfr deleted the clang-format-cleanups branch March 18, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants