-
Notifications
You must be signed in to change notification settings - Fork 53
COMP: Address clang-tidy warnings in generated code #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jcfr Do you have concerns with the change proposed? These changes clear at least 6 warnings for every executable that uses SEM PARSE_ARGS at the begining of the main function. |
|
Thanks for the reminder and for working on this 🙏 💯 Since the minimum version of C++ standard now supported is SlicerExecutionModel/CMakeLists.txt Line 19 in f19d6e8
|
ModuleDescriptionParser/Testing/TestData/parameter-file-with-pointfile-slicer-issue2979.params
Show resolved
Hide resolved
jcfr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address #136 before merging
Modernize the generateCLP main code, and generated code. Updating the generated code allows programs using SEM to build cleanly with clang-tidy.
30b7435 to
86d9ed4
Compare
|
@jcfr Can this now be merged? It has been open without substantive changes or concerns since the last august. |
|
@jcfr PING. |
|
Thanks for the ping 🙏 Will follow up on this 🚀 |
|
ping.. silent little ping.. barely audible. |
|
@hjmjohnson Are there any additional changes you would like to make here considering Slicer defined the minimum to C++17 since you last pushed changes here. Slicer/Slicer@dedb6c0 |
|
@jamesobutler Perhaps, but I don't want to hold this PR up any longer. It has been 18 months waiting for this step to be approved. I don't want to put any more effort into making this better until I know that previous efforts are considered. I don't know if this PR is rejected. |
|
Thanks for the reminder 🙏 and patience. Will integrate today 🚀 |
Modernize the generateCLP main code, and generated code.
Updating the generated code allows programs using
SEM to build cleanly with clang-tidy.