Refactor code to make it more readable and adaptable to Mega2560 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on extending the Elegoo Smart Robot Car Kit v4.0 with the DFPlayer mini module. In preparation I did some refactoring to the code to make it more readable. The changes also make reading from serial more robust.
Additionally, I've added RX and TX pins for the Mega2560 board that is needed to extend the Smart Robot Car Kit V4.0. By commenting in/out the respective lines it should be fairly easy to switch between an Uno and a Mega2560.
Feel free to pull those changes into your master from which I've forked. I've found your repository via a link in the free AZDelivery eBook about the DFPlayer module. So I guess, yours is the root upstream repository.