-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update API specifications with fern api update #3587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated OpenAPI schema: increased CreateBrowserSessionRequest.timeout maximum from 240 to 1440 minutes with description adjusted, and added optional azure_folder_path field to FileUploadBlockYAML (string or null). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 21258dd in 1 minute and 7 seconds. Click for details.
- Reviewed
40
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
3
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. fern/openapi/skyvern_openapi.json:4538
- Draft comment:
Updated timeout max from 240 to 1440. Confirm that sessions can run up to 24 hours as intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm their intention regarding the change in timeout value. This violates the rule against asking the author to confirm their intention or ensure behavior is intended.
2. fern/openapi/skyvern_openapi.json:4544
- Draft comment:
Timeout description updated to 1440 max. Ensure client docs and validations are aligned with this range. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. fern/openapi/skyvern_openapi.json:6323
- Draft comment:
New 'azure_folder_path' field added. Consider including a description or default value if applicable. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
Workflow ID: wflow_gkiyehLH56lfXesL
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Update API specifications by running fern api update.
📋 This PR updates the Skyvern OpenAPI specification with two key changes: extending the maximum session timeout from 240 to 1440 minutes (24 hours) and adding a new optional
azure_folder_path
field for Azure Blob storage configuration.🔍 Detailed Analysis
Key Changes
azure_folder_path
field to support folder-based organization within Azure Blob containersTechnical Implementation
Impact
Created with Palmier
Important
Update API specifications in
skyvern_openapi.json
to increase timeout limit and addazure_folder_path
field.maximum
timeout from 240 to 1440 inskyvern_openapi.json
.description
to reflect new timeout range (5 to 1440 minutes).azure_folder_path
field withstring
ornull
type inskyvern_openapi.json
.This description was created by
for 21258dd. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit