keep downloaded files after emailed

[LawyZheng]

Important

Remove file deletion after email attachment in SendEmailBlock's _build_email_message() function.

• Behavior:
  • Removed file deletion after email attachment in SendEmailBlock's _build_email_message().
• Misc:
  • Simplified file handling logic in _build_email_message() by removing unnecessary try-finally block.

^{This description was created by for 0c99c94. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0c99c94 in 16 seconds

More details

• Looked at 119 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:1328

• Draft comment:
  Calculating SHA256 for files that are not deleted might be unnecessary. Consider if this operation is still needed for your use case.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR removes the unlink operation, which was used to delete files after they were processed. This change is intentional to keep the files after they are emailed. However, the code still calculates the SHA256 hash of the files, which might not be necessary if the files are not being deleted. This could be a performance consideration.

Workflow ID: wflow_WBLCNZN28vPmteQG

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.