-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amazon nova support #1315
amazon nova support #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 57af243 in 17 seconds
More details
- Looked at
46
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:208
- Draft comment:
EnsureAWS_REGION
is set before registering Amazon Nova models to avoid runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_iJwH2HQlTWDnSh0n
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
57af243
to
1890b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 20117be in 14 seconds
More details
- Looked at
38
lines of code in2
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:221
- Draft comment:
The PR description mentionsBEDROCK_AMAZON_NOVA_MICRO
, but the code usesBEDROCK_AMAZON_NOVA_LITE
. Ensure the description matches the code changes. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ZiG63mbu7ZEcRLHU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
20117be
to
57ea73b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 57ea73b in 26 seconds
More details
- Looked at
52
lines of code in3
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. README.md:288
- Draft comment:
The LLM_KEY list contains a typo:BEDROCK_AMAZON_NOVA_MICRO
should beBEDROCK_AMAZON_NOVA_LITE
to match the configuration inconfig_registry.py
. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_8JnZlaZJzDtPiByn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Adds support for Amazon Nova models in AWS Bedrock configuration, updates
litellm
dependency, and modifiesREADME.md
to include new model keys.LLM_KEY
inREADME.md
to includeBEDROCK_AMAZON_NOVA_PRO
andBEDROCK_AMAZON_NOVA_MICRO
.BEDROCK_AMAZON_NOVA_PRO
andBEDROCK_AMAZON_NOVA_MICRO
inLLMConfigRegistry
inconfig_registry.py
withsupports_vision=True
andadd_assistant_prefix=True
.litellm
version to1.53.6
inpyproject.toml
.This description was created by for 57ea73b. It will automatically update as commits are pushed.