Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon nova support #1315

Merged
merged 2 commits into from
Dec 5, 2024
Merged

amazon nova support #1315

merged 2 commits into from
Dec 5, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 3, 2024

Important

Adds support for Amazon Nova models in AWS Bedrock configuration, updates litellm dependency, and modifies README.md to include new model keys.

  • Behavior:
    • Adds support for Amazon Nova models in AWS Bedrock.
    • Updates LLM_KEY in README.md to include BEDROCK_AMAZON_NOVA_PRO and BEDROCK_AMAZON_NOVA_MICRO.
  • Configuration:
    • Registers BEDROCK_AMAZON_NOVA_PRO and BEDROCK_AMAZON_NOVA_MICRO in LLMConfigRegistry in config_registry.py with supports_vision=True and add_assistant_prefix=True.
  • Dependencies:
    • Updates litellm version to 1.53.6 in pyproject.toml.

This description was created by Ellipsis for 57ea73b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 57af243 in 17 seconds

More details
  • Looked at 46 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:208
  • Draft comment:
    Ensure AWS_REGION is set before registering Amazon Nova models to avoid runtime errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_iJwH2HQlTWDnSh0n


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 20117be in 14 seconds

More details
  • Looked at 38 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:221
  • Draft comment:
    The PR description mentions BEDROCK_AMAZON_NOVA_MICRO, but the code uses BEDROCK_AMAZON_NOVA_LITE. Ensure the description matches the code changes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_ZiG63mbu7ZEcRLHU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit d8c6471 into main Dec 5, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/amazon_nova branch December 5, 2024 08:12
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 57ea73b in 26 seconds

More details
  • Looked at 52 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. README.md:288
  • Draft comment:
    The LLM_KEY list contains a typo: BEDROCK_AMAZON_NOVA_MICRO should be BEDROCK_AMAZON_NOVA_LITE to match the configuration in config_registry.py.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_8JnZlaZJzDtPiByn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant