Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove streaming debugging log #1300

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 2, 2024

Important

Remove exception logging in get_streaming_file method in local.py.

  • Logging:
    • Remove exception logging in get_streaming_file method in local.py.

This description was created by Ellipsis for e532a05. It will automatically update as commits are pushed.

@wintonzheng wintonzheng merged commit d18f2d4 into main Dec 2, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/remove_debugging_log_for_local_streaming branch December 2, 2024 07:57
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e532a05 in 7 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/artifact/storage/local.py:84
  • Draft comment:
    Consider re-adding the logging statement to provide visibility into errors during file retrieval. This can aid in debugging and monitoring.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the logging statement in the get_streaming_file method could lead to a lack of visibility into errors that occur during file retrieval. This might make debugging more difficult if issues arise.

Workflow ID: wflow_11VNElgdR7kbAK1U


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant