Skip to content

Tags: Skyscanner/turbolift

Tags

3.1.1

Toggle 3.1.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
feat(create_prs): check whether PR description file has been updated (#…

…145)

* prompt for unchanged or empty description

* check for todos only

* test title and body separately

* no need to check dir name

* extract into vars

---------

Co-authored-by: Danny Ranson <danny.ranson@skyscanner.net>

3.1.0

Toggle 3.1.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add file output to foreach command (#141)

* Add file output to foreach command

* Reorder

* Simplify code

3.0.0

Toggle 3.0.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix(foreach): Remove shell invocation from foreach (#136)

* Remove shell invocation from foreach

As discussed in [issue 135], turbolift applies shell escaping
inconsistently on the arguments in foreach. Upon consideration, I think
there is no good reason to apply shell escaping at all. It makes
turbolift more fragile, more confusing and ultimately less flexible.

Instead, do not use a shell at all and all these problems disappear.
None of the examples in the README use this functionality. If users do
need to invoke a shell, for example to do redirection, it is much more
explicit and understandable for them if they do it themselves.

This PR:

* Removes the use of a shell, instead directly executing a subprocess
  based on the arguments provided.
* Removes custom handling of arguments. Users are directed to the
  standard GNU-style `--` to indicate that everything else on the
  command-line is an argument, not an option. This makes the code
  substantially simpler.

[issue 135]: #135

* Format foreach shell arguments nicely

Shell escape the arguments so you can tell when arguments have spaces in
them.

* Require -- before foreach command

Since we are deliberately removing custom handling of arguments, users
will find that if they don't include a double hypen (`--`) separator
before their foreach command, any options they pass to their command
will be interpreted by turbolift and either result in errors, or worse,
being quietly omitted from their command (e.g. `-v`), which could be
surprising and frustrating!

To head this off, refuse immediately if `--` either doesn't appear on
the command-line, or appears after one or more arguments.

* Reword foreach usage for accuracy

Make it clear that the double-hyphen separator `--` is mandatory and not
just a good idea.

* Wrap long usage message

Turns out Cobra doesn't wrap usage messages, so they look pretty ugly if
we don't pick a pretty conservative width and wrap by hand.

* Fix [flags] appearing at end of usage

Turns out Cobra searches your usage line for the specific text "[flags]"
and if it doesn't find it, shoves it on the end. Gross. For that reason,
let's remove explicit callout of any flags and move it back to *before*
the double-hyphen.

* Improve logged command format and add tests

Wrap braces around the logged command to delimit it clearly. Add unit
tests to cover argument formatting.

* Add foreach absolute path example

---------

Co-authored-by: Daniel Ranson <92924979+Dan7-7-7@users.noreply.github.com>

2.4.1

Toggle 2.4.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (#137)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 5.1.0 to 6.0.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@9d1e062...a4f60bb)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Richard North <rich.north@gmail.com>

2.4.0

Toggle 2.4.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update PR descriptions (#117)

* add update PR description

* add github tests

* tests for updating via default readme

* custom description file, instructions

* Update README.md

Co-authored-by: Richard North <rich.north@gmail.com>

* Update README.md

Co-authored-by: Richard North <rich.north@gmail.com>

* test for default description file

---------

Co-authored-by: Danny Ranson <danny.ranson@skyscanner.net>
Co-authored-by: Richard North <rich.north@gmail.com>

2.3.1

Toggle 2.3.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Revert "Clone repositories with a depth of 1 (#104)" (#116)

This reverts commit c45db62.

Co-authored-by: Danny Ranson <danny.ranson@skyscanner.net>

2.3.0

Toggle 2.3.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Bump actions/setup-go from 2 to 4 (#112)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Ranson <92924979+Dan7-7-7@users.noreply.github.com>

2.2.0

Toggle 2.2.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Bump golang.org/x/sys from 0.0.0-20210603125802-9665404d3644 to 0.1.0 (

…#93)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

2.1.1

Toggle 2.1.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add Homebrew tap publication (#85)

2.1.0

Toggle 2.1.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Adds `update-prs` with `close` feature (#72)

* Adds `update-prs` with `close` feature

Relates to #65
Fixes #60
Relates to #67

This PR implements a global PR closing command.
It introduces a new `update-prs` verb which has only one option
at the moment: `--close`.

It uses the same mechanism as in #67, looking at the PRs and identifying
the one related to the campain, then closes it.

It handles the case where there is no open PR.

* Update after PR comments

- typos
- Readme addition

Signed-off-by: Sebastien Le Digabel <sledigabel@gmail.com>

Co-authored-by: Richard North <rich.north@gmail.com>