Prompt for unchanged or empty PR description #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in manual testing this is now working as expected, but it needs to be improved on and the tests updated |
rnorth
reviewed
Aug 8, 2024
rnorth
reviewed
Aug 8, 2024
| @@ -68,6 +71,15 @@ func run(c *cobra.Command, _ []string) { | |||
| readCampaignActivity.EndWithFailure(err) | |||
| return | |||
| } | |||
| prDescriptionUnchanged, err := campaign.PrDescriptionUnchanged(dir) | |||
There was a problem hiding this comment.
Could we perhaps rename the function to IsPrDescriptionUnchanged? Unless there is any precedent in other boolean-returning functions?
rnorth
reviewed
Aug 8, 2024
| } | ||
|
|
||
| func PrDescriptionUnchanged(dir *Campaign) (bool, error) { | ||
| tempPrDescriptionFile, err := os.Create("turbolift-temp-pr-description-*") |
There was a problem hiding this comment.
Could we make this work without creating a new file? e.g. if applyTemplate accepted an io.Writer or a buffer instead of a file, and file creation were moved out of it.
Then this function could avoid creating a new file, and instead just read the real file and compare its string contents...
|
this was unnecessarily complicated, closing in favour of #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with #124
Also adds a missing test for creating PRs with custom description file.
In order to test whether the PR description has been changed, I had to reuse the method that creates the README.md on
turbolift init, but with a temporary file. For this to work it was necessary to move some functionality out of init and into campaign.