-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add first version of CLI #90
Conversation
I'm not completely sure about including click by default, this will increase the payload size if it's deployed as a lambda, we might want to make it optional. How big is click? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments to review, but other than those this looks good to me, and a good addition to CFRipper! :)
cfripper/cli.py
Outdated
|
||
|
||
def save_to_file(file: Path, result: str) -> None: | ||
file.write_text(result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file is a keyword
cfripper/cli.py
Outdated
process_template(template=template, resolve_parameters=resolve_parameters, **kwargs) | ||
|
||
except Exception as e: | ||
logging.exception(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a useful text here. The exception itself is logged regardless
Add first version of a CLI
Examples
Help output
Normal execution
Using resolve flag
Using json format and output-folder argument