Fix RestAPI IApiResponse disposing the HTTP response before the caller owns it - #214
Merged
Conversation
…r owns it. Transfer ownership when returning the wrapper, rethrow caller cancellation, and coerce ExceptionFactory results to ApiExceptionBase. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IApiResponsealready owns theHttpResponseMessageviaIDisposable, butRestApiBridge.SendAsyncdisposed that response infinallybefore the caller could use it.This PR transfers ownership when returning the wrapper, rethrows caller cancellation instead of wrapping it as
ApiRequestException, and coerces non-ApiExceptionBaseExceptionFactoryresults soErrorandIsSuccessfulstay consistent.Related Issue
Fixes #213
Parent map: #212
Solution module
Type of change
Test plan
dotnet test Observables.RestAPI/Observables.RestAPI.Tests/Observables.RestAPI.Tests.csproj(net8.0 and net10.0: 9 passed). net9.0 failed locally with a missingapphost.execopy (SDK/obj), unrelated to this change.Breaking changes
IApiResponsenow throwsOperationCanceledExceptioninstead of returning a wrapper withError(aligned with the existing deserialize path). Timeout-like cancel onSendAsyncis stillApiRequestException.SendVoidAsyncis unchanged.Checklist
docs/design/restapi.mdis the Docs module (follow-up from Wayfinder: post-0.2.0 bug hunt and shallow-module deepening #212)