Add shared-library regression coverage to close the #150 detection gap - #152
Open
janstaelensskyline wants to merge 2 commits into
Open
Add shared-library regression coverage to close the #150 detection gap#152janstaelensskyline wants to merge 2 commits into
janstaelensskyline wants to merge 2 commits into
Conversation
The existing BOOST-DailyRegression-* repos contain no project that is referenced by a sibling project, so nothing in the downstream suite ever depended on MSBuild resolving a ProjectReference before compiling its consumer. That gap is why #150 passed the full downstream suite and still broke real solutions with: CSC : error CS0006: Metadata file '<shared library>.dll' could not be found BOOST-DailyRegression-SharedLibrary closes it. Its solution combines a wide flat fan-out (Consumer1..6 -> SharedLibrary) with a four-level chain (SharedLibrary -> MidLevelLibrary -> BranchLibrary* -> TopLevelApp); the chain makes the failure deterministic rather than a flaky race. Verified end to end: the repo fails against the pre-fix commit with CS0006 in "Build remaining projects" and passes against current main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The header described a .github/workflows/test-downstream.yml receiver, but every registered downstream repo actually uses pr-regression.yml calling the shared BOOST-DailyRegression orchestrator. Document what is actually wired up, verified end to end against the new repo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
Receiver wiring verifiedFired the real
The orchestrator's branch run, release tagging and tag run all completed, so the repo behaves exactly like its siblings. Also pushed a small doc correction: the Secrets still to set (org admin)Not blocking the coverage this PR adds — the build runs green without them — but for parity with the sibling repos someone with admin rights should add to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The existing
BOOST-DailyRegression-*repos contain no project that is referenced by a sibling project. Nothing in the downstream suite ever depended on MSBuild resolving aProjectReferencebefore compiling its consumer.That is the exact gap that let #150 through: it passed the entire downstream suite, then broke real solutions with
and had to be fixed in #151.
What
New regression repo:
SkylineCommunications/BOOST-DailyRegression-SharedLibrary, registered here againstMaster Workflow.yml.Its solution deliberately combines the two shapes that were observed to fail:
Every project genuinely consumes types from what it references, so the references can't be optimised away.
Verification
End-to-end, on the real runner:
0ff78eb)Build remaining projects,CS0006onSharedLibrary.dllandMidLevelLibrary.dllmain(fixed)So the repo demonstrably detects this class of regression rather than just existing. It also reproduces locally with a plain
dotnet build ... -p:BuildProjectReferences=false(exit 1) vs. without (exit 0) — documented in its README.The temporary verification branch has been deleted.
Notes
DOWNSTREAM_MAPJSON validated (7 entries parse).ci-cd.yml(@main),pr-ci-cd.yml(@test-downstream),regression.yml(daily),pr-regression.yml(repository_dispatchreceiver).SONAR_NAME/SONAR_TOKEN/TEAMS_WEBHOOKare not yet set on the new repo, so SonarCloud and the Teams notification are inert until someone configures them. The build coverage this PR is about works regardless.