Conversation
|
yeah sure thats probably right |
There was a problem hiding this comment.
Pull Request Overview
This PR adds numerous missing accessories to the Skyblock accessories configuration file. The update includes both new accessory chains and fixes to existing accessory naming and upgrade paths.
- Adds multiple new accessory upgrade chains (coins, chocolate, soul campfire, etc.)
- Fixes naming inconsistencies in existing accessories (anita_talisman series, scavenger series)
- Adds standalone accessories without upgrade paths
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "upgrade": "scavanger_ring" | ||
| }, | ||
| "scavanger_ring": { | ||
| "rarity": "uncommon", | ||
| "upgrade": "scavanger_artifact" | ||
| }, | ||
| "scavanger_artifact":{ |
There was a problem hiding this comment.
Corrected spelling of 'scavanger' to 'scavenger' in multiple accessory names.
| "upgrade": "scavanger_ring" | |
| }, | |
| "scavanger_ring": { | |
| "rarity": "uncommon", | |
| "upgrade": "scavanger_artifact" | |
| }, | |
| "scavanger_artifact":{ | |
| "upgrade": "scavenger_ring" | |
| }, | |
| "scavenger_ring": { | |
| "rarity": "uncommon", | |
| "upgrade": "scavenger_artifact" | |
| }, | |
| "scavenger_artifact":{ |
| "upgrade": "runeblade_ring" | ||
| }, | ||
| "runeblade_ring": { | ||
| "rarity":"uncommon", |
There was a problem hiding this comment.
Missing space after colon in JSON object. Should be 'rarity': 'uncommon' for consistency with other entries.
| "rarity":"uncommon", | |
| "rarity": "uncommon", |
| }, | ||
| "small_fish_bowl": { | ||
| "rarity": "common", | ||
| "upgrade":"medium_fish_bowl" |
There was a problem hiding this comment.
Missing space after colon in JSON object. Should be 'upgrade': 'medium_fish_bowl' for consistency with other entries.
| "upgrade":"medium_fish_bowl" | |
| "upgrade": "medium_fish_bowl" |
| "century_ring": { | ||
| "rarity": "uncommon", | ||
| "upgrade": null | ||
| }, | ||
| "magic_8_ball": { | ||
| "rarity": "rare", | ||
| "upgrade": null | ||
| }, | ||
| "runebook": { | ||
| "rarity": "common", | ||
| "upgrade": null | ||
| }, | ||
| "general_medallion": { | ||
| "rarity": "rare", | ||
| "upgrade": null | ||
| }, | ||
| "dwarven_metal": { | ||
| "rarity": "uncommon", | ||
| "upgrade": null | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation using 5 spaces instead of 4 spaces like the rest of the file. Should use 4 spaces for consistency.
| "century_ring": { | |
| "rarity": "uncommon", | |
| "upgrade": null | |
| }, | |
| "magic_8_ball": { | |
| "rarity": "rare", | |
| "upgrade": null | |
| }, | |
| "runebook": { | |
| "rarity": "common", | |
| "upgrade": null | |
| }, | |
| "general_medallion": { | |
| "rarity": "rare", | |
| "upgrade": null | |
| }, | |
| "dwarven_metal": { | |
| "rarity": "uncommon", | |
| "upgrade": null | |
| } | |
| "century_ring": { | |
| "rarity": "uncommon", | |
| "upgrade": null | |
| }, | |
| "magic_8_ball": { | |
| "rarity": "rare", | |
| "upgrade": null | |
| }, | |
| "runebook": { | |
| "rarity": "common", | |
| "upgrade": null | |
| }, | |
| "general_medallion": { | |
| "rarity": "rare", | |
| "upgrade": null | |
| }, | |
| "dwarven_metal": { | |
| "rarity": "uncommon", | |
| "upgrade": null | |
| } |
2 participants
This should be the bulk of missing accessories.