Conversation
| git_override( | ||
| module_name = "skywalking-data-collect-protocol", | ||
| commit = "fb3fb005650e2489164978b7804117c7ade1529a", | ||
| remote = "https://github.com/apache/skywalking-data-collect-protocol.git", | ||
| ) |
There was a problem hiding this comment.
Notice, this is pointing to skywalking-data-collect-protocol last commit, to confirm its bazel mode migration and will be working properly when its next tag is published
See https://bazel.build/rules/lib/globals/module#git_override for more
|
/cc @wbpcode |
148823a to
78828eb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Bazel WORKSPACE to Bzlmod module system, following the official Bzlmod Migration Guide. The changes update dependency management, version pins, and build configuration to work with the new module system.
- Adds MODULE.bazel file with module dependencies using bazel_dep declarations
- Updates dependency versions across all external libraries (grpc, protobuf, googletest, etc.)
- Modifies build configuration to enable bzlmod and enforce C++17 standard
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MODULE.bazel | New module file defining dependencies with bazel_dep and git_override |
| WORKSPACE.bzlmod | New workspace file for bzlmod compatibility |
| .bazelrc | Enables bzlmod and enforces C++17 standard across platforms |
| .bazelversion | Updates Bazel version from 4.0.0 to 7.6.1 |
| bazel/repositories.bzl | Updates dependency versions and URLs to match MODULE.bazel |
| WORKSPACE | Removes rules_proto_toolchains and adds protobuf_deps |
| cpp2sky/BUILD | Updates protobuf import to use new location |
| bazel/fmtlib.BUILD | Renames target from "fmtlib" to "fmt" |
| bazel/spdlog.BUILD | Updates dependency reference to match renamed fmt target |
| test/tracing_context_test.cc | Updates include path for protocol buffer headers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I believe the jobs don’t start because github doesn’t supports Ubuntu 20.04 anymore, I opened #136 I'll have to adapt this PR once the other is merged. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
I restored the sudo calls for cmake, we shall be closer to success with that change. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Removed C++ standard specification from cmake commands.
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for the contribution. LGTM. Hope CI is happy.
…ing CI workflow Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
b455b89 to
32e0499
Compare
|
@wbpcode, |
…azel coverage Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…M version Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , |
…paths Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
🙏 |
…solution Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , Working locally, let's hope that's final round on this. |
3a5afb7 to
2806210
Compare
…sistency and add lld Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , |
Comment out installation and coverage test steps in CI workflow.
|
@wbpcode , |
I am OK, let's me try to pick it up. I added it long time ago anyway. |
Description
This setup bazel module support. It follows Bzlmod Migration Guide
Notice:
Closes #136