Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide percentage-based sampling #57

Closed
1 of 4 tasks
liuhaoyang opened this issue Jun 10, 2018 · 0 comments
Closed
1 of 4 tasks

Provide percentage-based sampling #57

liuhaoyang opened this issue Jun 10, 2018 · 0 comments
Assignees
@liuhaoyang
Labels
enhancement New feature or request
Milestone
0.8.0

Comments

@liuhaoyang
Copy link
Collaborator

liuhaoyang commented Jun 10, 2018 •
edited
Loading

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

  • Please describe about your requirements or improvement suggestions.

Currently our sampling mechanism only supports match the first N trace segments in the certain time window. But in some cases, we want to get more balanced sampling, such as percentage-based sampling, so we need to restructure SamplingService to provide multiple sampling implementations for the user to choose.
@liuhaoyang liuhaoyang added the enhancement New feature or request label Jun 10, 2018
@liuhaoyang liuhaoyang added this to the 0.4.0 milestone Jun 10, 2018
@liuhaoyang liuhaoyang self-assigned this Jun 10, 2018
@liuhaoyang liuhaoyang modified the milestones: 0.4.0, 0.8.0 Jan 21, 2019
liuhaoyang added a commit that referenced this issue Feb 12, 2019
@liuhaoyang
Resolve issue #57 : Provide percentage-based sampling
6ea01a7
liuhaoyang added a commit that referenced this issue Feb 13, 2019
@liuhaoyang
Refactor tracing context (#139)
2f24067 
* Delete `ISkyWalkingClient` interface

* Use segment protocol V2

* Forget the old api. All context apis will be overwritten.

* Add segments define

* Add some apis

* Add carrierParser

* Add SegmentContextAccessor API

* Add SampledDelegate interface

* Add thread-safe  SamplerChainBuilder

* Add SegmentContextFactory

* Add ITracingContext Interface

* Refactoring the core API for tracing context

* remove utils package

* Resolve issue #57 : Provide percentage-based sampling

* Refactor HttpClient Tracing

* Fix header carrier

* Add async exitSpan sample

* Add Task.WhenAll sample

* Refactor EntityFrameworkCore tracing

* Refactor SqlClient & CAP Tracing

* Refactor Asp.Net tracing

* Remove outdated APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuhaoyang liuhaoyang

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@liuhaoyang