ExprRegions #18
Open
ExprRegions #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneBeee
suggested changes
Feb 26, 2025
src/main/java/org/skriptlang/skriptworldguard/elements/expressions/ExprRegions.java
Outdated
Show resolved
Hide resolved
…ions/ExprRegions.java Co-authored-by: Shane Bee <shanebolenback@me.com>
ShaneBeee
reviewed
Feb 26, 2025
src/main/java/org/skriptlang/skriptworldguard/elements/expressions/ExprRegions.java
Outdated
Show resolved
Hide resolved
…ions/ExprRegions.java Co-authored-by: Shane Bee <shanebolenback@me.com>
ShaneBeee
approved these changes
Feb 26, 2025
Efnilite
suggested changes
Feb 26, 2025
src/main/java/org/skriptlang/skriptworldguard/worldguard/RegionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skriptworldguard/worldguard/RegionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skriptworldguard/elements/expressions/ExprRegions.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
Feb 26, 2025
sovdeeth
requested changes
Apr 15, 2025
Comment on lines
+162
to
+164
| managers.put(world1, container.get(BukkitAdapter.adapt(world1))); | ||
| } else { | ||
| managers.put(world, container.get(BukkitAdapter.adapt(world))); |
There was a problem hiding this comment.
Why aren't these using getRegionManager()? I'd think the loss of benefits of caching the container would be outweighed by the improvements to readability.
APickledWalrus
requested changes
May 16, 2025
| public class ExprRegions extends SimpleExpression<WorldGuardRegion> { | ||
|
|
||
| static { | ||
| Skript.registerExpression(ExprRegions.class, WorldGuardRegion.class, ExpressionType.SIMPLE, |
There was a problem hiding this comment.
Suggested change
| Skript.registerExpression(ExprRegions.class, WorldGuardRegion.class, ExpressionType.SIMPLE, | |
| Skript.registerExpression(ExprRegions.class, WorldGuardRegion.class, ExpressionType.COMBINED, |
due to presence of expression (even if optional)
| WorldGuardRegion[] worldRegions = RegionUtils.getRegions(world); | ||
| if (worldRegions == null || worldRegions.length == 0) | ||
| continue; | ||
| regions.addAll(Arrays.stream(worldRegions).collect(Collectors.toList())); |
There was a problem hiding this comment.
Suggested change
| regions.addAll(Arrays.stream(worldRegions).collect(Collectors.toList())); | |
| regions.addAll(Arrays.asList(worldRegions)); |
Any reason for using a stream?
|
|
||
| @Override | ||
| public String toString(@Nullable Event event, boolean debug) { | ||
| return "all of the regions" + (worlds == null ? "" : " " + worlds.toString(event, debug)); |
There was a problem hiding this comment.
Suggested change
| return "all of the regions" + (worlds == null ? "" : " " + worlds.toString(event, debug)); | |
| return "all of the regions" + (worlds == null ? "" : " in " + worlds.toString(event, debug)); |
Might be worth specifying this
| * @param world The {@link World} to get regions from, or {@code null} to get regions from all worlds | ||
| * @return All regions from the world, or all worlds if {@code world} is null. | ||
| */ | ||
| public static WorldGuardRegion @Nullable [] getRegions(@Nullable World world) { |
There was a problem hiding this comment.
Why are these methods nullable? They don't appear to return null (nor should they - just return an empty array)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow users to get all regions from all worlds or specific worlds.
javaw_QIuU5pB6VJ.mp4