Add support for a negation/fail check on CondChance #8320
+52
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
requested review from
Burbulinis and
Pesekjak
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Fusezion
commented
Dec 15, 2025
Comment on lines
60
to
62
| String baseString = "chance of " + chance.toString(event, debug) + (percent ? "%" : ""); | ||
| if (isNegated()) baseString += " failed"; | ||
| return baseString; |
Contributor
Author
There was a problem hiding this comment.
Quick note this doesn't use a SyntaxStringBulder as it would cause with percentage to format as chance of 10 %
edit: fixed the usage of if () baseString += "" not being on a new line
sovdeeth
approved these changes
Dec 15, 2025
| @Override | ||
| public boolean init(final Expression<?>[] exprs, final int matchedPattern, final Kleenean isDelayed, final ParseResult parser) { | ||
| public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) { | ||
| //noinspection unchecked |
Member
There was a problem hiding this comment.
you can leave this as a suppression on the method if you'd like
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Contributor
Author
|
per smurfy's request in my dms, I've implemented a simplified condition, this is my first time interacting with this so let me know if anything should be changed. |
sovdeeth
approved these changes
Dec 15, 2025
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Efnilite
changed the title
Efnilite
approved these changes
Dec 16, 2025
skriptlang-automation
bot
added
feature-ready
sovdeeth
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In skript there is no way currently to get the negated result of a
CondChancewithout 4 semi annoying work arounds.10%->90%0-1value use1 - xelseSolution
In order to provide developers a more flexible condition I'm proposing to add a new end bit for whether it failed
i.e.
if chance of 10% failedallowing easier and simpler guard conditions in their codeTesting Completed
Manual testing was completed with a debug method added within the
checkmethodSupporting Information
While doing this I've taken the chance to update methods and annotations to skript's newer designs, wasn't sure if the team wanted this swapped too the new registration api or where you'd want it moved to if so.
Completes: #8319
Related: none
AI assistance: none