Enable errors in Region converter during parsing #8278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
Burbulinis and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
approved these changes
Nov 7, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
APickledWalrus
approved these changes
Nov 7, 2025
skriptlang-automation
bot
removed
the
needs reviews
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
added
the
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Errors involving missing or duplicate regions were exceedingly hard to debug due to no specific error messages being sent. The parser has errors, but the converter does not and the converter was being used.
This is because there are mainfarm regions in 2 separate worlds, but you'd never know that.
Solution
Enables errors in the converter when the parser instance is active:
Testing Completed
Manual testing. I confirmed this only errors during parsing and not otherwise, including on load.
Supporting Information
Completes: none
Related: none