Fix matching function signatures with a single list parameter #8245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
UnderscoreTud
approved these changes
Oct 18, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
skriptlang-automation
bot
added
patch-ready
Absolutionism
approved these changes
Oct 18, 2025
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
removed
the
patch-ready
APickledWalrus
moved this from Done - Awaiting Release
to Done - Released
in 2.13 Releases
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Skript would fail to identify
foo(n: numbers)andfoo(n: numbers)as the same function signature. This resulted in an api exception when attempting to load the second function, rather than a nice parse error.This was due to a failure to convert array types to their component types when looking for converters, which would always fail.
Solution
Ensures array types are unwrapped when matching signatures.
Testing Completed
Supporting Information
Completes: none
Related: none