Skip to content

Conversation

@CJH3139
Copy link
Contributor

@CJH3139 CJH3139 commented Oct 7, 2025

Problem

https://skripthub.net/docs/?id=1135
The examples from the doc showed pull player along vector(1,1,1) at speed 1.5 when pull wasn't a syntax for that effect

Solution

(push|thrust) -> (push|thrust|pull)

Testing Completed

Tested manually in game & added 2 lines on EffPush.sk
image

Supporting Information


Completes: none
Related: none

@CJH3139 CJH3139 requested a review from a team as a code owner October 7, 2025 05:10
@CJH3139 CJH3139 requested review from Pesekjak and cheeezburga and removed request for a team October 7, 2025 05:10
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 7, 2025
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Oct 7, 2025
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@CJH3139 CJH3139 requested a review from sovdeeth October 7, 2025 05:38
@CJH3139 CJH3139 requested a review from sovdeeth October 7, 2025 05:44
@sovdeeth sovdeeth removed their request for review October 7, 2025 05:45
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't pull use the opposite direction of push?

@sovdeeth
Copy link
Member

sovdeeth commented Oct 9, 2025

shouldn't pull use the opposite direction of push?

Why would it? If I pull you north, am I actually pushing you south? Pulling and pushing have the same effect on the target, the difference is where the imaginary force is coming from.

@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Oct 12, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Oct 15, 2025
@APickledWalrus APickledWalrus merged commit 83a15eb into SkriptLang:dev/feature Oct 15, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Oct 15, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. needs reviews A PR that needs additional reviews

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

4 participants