-
-
Notifications
You must be signed in to change notification settings - Fork 416
Paper 1.21.10 Update #8219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper 1.21.10 Update #8219
Conversation
…21-9 # Conflicts: # src/main/java/ch/njol/skript/entity/MinecartData.java
…21-9 # Conflicts: # src/test/skript/environments/java21/paper-1.21.9.json
sovdeeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like chunkloading isn't quite working. May need to use the chunk ticket api
|
Bruh changed the chunk loading 100, 100 to 0, 0 |
Yes, previously 100,100 was used to ensure the chunks outside of the spawn chunks were ready, but since there's no more spawn chunks it shouldn't matter between 100 and 0. There wasn't anything special at 100, 100 as far as I know. |
|
100, 100 was indeed arbitrarily chosen |
I'm not sure why it's not working here, running both Java 17 and Java 21 locally is fine and passes. Edit: Does not work either |
Try loading a radius of chunks around 0,0 |
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
* Initial Commit * copper golem * Update Skript.java * Update Skript.java * Attempt 2 * Attempt 3 * Attempt 4 * Attempt 5 * Attempt 6 * Attempt 7 * Attempt 8 * Attempt 9 * Attempt 10 * Attempt 11 * Attempt 12 * Attempt 13 * Attempt 14 * Update src/main/java/ch/njol/skript/Skript.java * 1.21.10
* Initial Commit * copper golem * Update Skript.java * Update Skript.java * Attempt 2 * Attempt 3 * Attempt 4 * Attempt 5 * Attempt 6 * Attempt 7 * Attempt 8 * Attempt 9 * Attempt 10 * Attempt 11 * Attempt 12 * Attempt 13 * Attempt 14 * Update src/main/java/ch/njol/skript/Skript.java * 1.21.10
Problem
Skript has not yet added support for Paper 1.21.9. Leaving out anything new that was added or changed in Minecraft.
Solution
Update the Paper API and gradle.properties.testEnv to 1.21.9
Updates
CondPvPandEffPvPas pvp is enabled through a gamemode setting now.Removes method field and spawn method in
EntityDatathat deals with using Bukkits consumer as it's not present in any of the supported versions.Grabs
World#isEnabledByFeatureand stores in a method as 1.21.9 now usesFeatureFlagSetHolder#isEnabled. Additionally the new route is also stored in a method as it was throwing exceptions on older versions.Updates ExprSkullOwner, as grabbing the owner was changed for blocks in 1.21.9, previous way was causing the test to fail.
Updates VisualEffects, registers more data suppliers as a new particle data type was introduced and is required for "effect" and "instant effect". As well as a float for "dragon breath" and color for "flash"
Adds copper golem
Adds mannequin (base, nothing special)
Adds new spawn reasons
1.21.9 removed spawn chunks, now the chunk where tests take place, is loaded internally before tests are ran.
Testing Completed
quickTestSupporting Information
N/A
Completes: none
Related: none