Skip to content

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Oct 2, 2025

Problem

Skript has not yet added support for Paper 1.21.9. Leaving out anything new that was added or changed in Minecraft.

Solution

Update the Paper API and gradle.properties.testEnv to 1.21.9
Updates CondPvP and EffPvP as pvp is enabled through a gamemode setting now.
Removes method field and spawn method in EntityData that deals with using Bukkits consumer as it's not present in any of the supported versions.
Grabs World#isEnabledByFeature and stores in a method as 1.21.9 now uses FeatureFlagSetHolder#isEnabled. Additionally the new route is also stored in a method as it was throwing exceptions on older versions.
Updates ExprSkullOwner, as grabbing the owner was changed for blocks in 1.21.9, previous way was causing the test to fail.
Updates VisualEffects, registers more data suppliers as a new particle data type was introduced and is required for "effect" and "instant effect". As well as a float for "dragon breath" and color for "flash"
Adds copper golem
Adds mannequin (base, nothing special)
Adds new spawn reasons
1.21.9 removed spawn chunks, now the chunk where tests take place, is loaded internally before tests are ran.

Testing Completed

quickTest

Supporting Information

N/A


Completes: none
Related: none

…21-9

# Conflicts:
#	src/main/java/ch/njol/skript/entity/MinecartData.java
…21-9

# Conflicts:
#	src/test/skript/environments/java21/paper-1.21.9.json
@Absolutionism Absolutionism requested review from a team as code owners October 2, 2025 03:47
@Absolutionism Absolutionism requested review from Burbulinis, erenkarakal and sovdeeth and removed request for a team October 2, 2025 03:47
@Absolutionism Absolutionism moved this to In Review in 2.13 Releases Oct 2, 2025
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 2, 2025
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like chunkloading isn't quite working. May need to use the chunk ticket api

@TheLimeGlass
Copy link
Contributor

Bruh changed the chunk loading 100, 100 to 0, 0

@sovdeeth
Copy link
Member

sovdeeth commented Oct 3, 2025

Bruh changed the chunk loading 100, 100 to 0, 0

Yes, previously 100,100 was used to ensure the chunks outside of the spawn chunks were ready, but since there's no more spawn chunks it shouldn't matter between 100 and 0. There wasn't anything special at 100, 100 as far as I know.

@Efnilite
Copy link
Member

Efnilite commented Oct 3, 2025

100, 100 was indeed arbitrarily chosen

@Absolutionism
Copy link
Contributor Author

Absolutionism commented Oct 3, 2025

Looks like chunkloading isn't quite working. May need to use the chunk ticket api

I'm not sure why it's not working here, running both Java 17 and Java 21 locally is fine and passes.
Using the chunk ticket ended up causing the tests to not be ran, locally.
Trying setForceLoaded right now, passed locally, see if it works on GitHubs end.

Edit: Does not work either

@sovdeeth
Copy link
Member

sovdeeth commented Oct 3, 2025

Looks like chunkloading isn't quite working. May need to use the chunk ticket api

I'm not sure why it's not working here, running both Java 17 and Java 21 locally is fine and passes. Using the chunk ticket ended up causing the tests to not be ran, locally. Trying setForceLoaded right now, passed locally, see if it works on GitHubs end.

Edit: Does not work either

Try loading a radius of chunks around 0,0
The test that fails requires the spawn of the world to be loaded, which is not always going to be at 0,0. We should also standardized the world spawn before running tests, eg setting it to 0,0 ourselves. It's likely 1.20.4 is failing because it still needs the loading of something outside the spawn chunks.

@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 3, 2025
@Absolutionism Absolutionism requested a review from sovdeeth October 4, 2025 00:34
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Oct 7, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Oct 7, 2025
@Absolutionism Absolutionism changed the title Paper 1.21.9 Update Paper 1.21.10 Update Oct 15, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to In Review in 2.13 Releases Oct 15, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Oct 15, 2025
@Absolutionism Absolutionism merged commit 92ea365 into SkriptLang:dev/feature Oct 15, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Oct 15, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* copper golem

* Update Skript.java

* Update Skript.java

* Attempt 2

* Attempt 3

* Attempt 4

* Attempt 5

* Attempt  6

* Attempt 7

* Attempt  8

* Attempt 9

* Attempt 10

* Attempt 11

* Attempt 12

* Attempt 13

* Attempt 14

* Update src/main/java/ch/njol/skript/Skript.java

* 1.21.10
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* copper golem

* Update Skript.java

* Update Skript.java

* Attempt 2

* Attempt 3

* Attempt 4

* Attempt 5

* Attempt  6

* Attempt 7

* Attempt  8

* Attempt 9

* Attempt 10

* Attempt 11

* Attempt 12

* Attempt 13

* Attempt 14

* Update src/main/java/ch/njol/skript/Skript.java

* 1.21.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

6 participants