Skip to content

Change registerExpression() parameter name #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Absolutionism merged 2 commits into from
Sep 17, 2025
Merged

Change registerExpression() parameter name #8180

Absolutionism merged 2 commits into from
Sep 17, 2025

Conversation

@erenkarakal
Copy link
Member

@erenkarakal erenkarakal commented Sep 8, 2025

Problem

The expressionType parameter is misnamed. While other register methods use conditionClass, this method uses expressionType, which can be mistaken with the ExpressionType class

Solution

Renamed the parameter to match other register methods

Testing Completed

Completes: none
Related: none

@erenkarakal erenkarakal requested review from a team as code owners September 8, 2025 23:23
@erenkarakal erenkarakal requested review from APickledWalrus and TheMug06 and removed request for a team September 8, 2025 23:23
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Sep 8, 2025
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Sep 9, 2025
@Absolutionism Absolutionism merged commit e463ce4 into SkriptLang:dev/patch Sep 17, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Sep 17, 2025
@Absolutionism Absolutionism moved this to Done - Awaiting Release in 2.13 Releases Sep 17, 2025
sovdeeth added a commit that referenced this pull request Oct 1, 2025
@sovdeeth
Runtime error for when EffSort aborts due to null value (#8206)
3983fa7 
* Swap reset and delete errors in EffChange (#8177)

swap reset and delete errors

* Fix improper grammar in update block syntax (#8072)

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Fix Incorrect Variable Change Queue Processing (#8182)

Fix incorrect change processing order

* Change registerExpression() parameter name (#8180)

change parameter name

* Move EvtRealTime to main thread (#8185)

* Fix type-aware function parsing for functions with only optional arguments (#8189)

Account for functions with all optional parameters

* Properly parse exprsecs in function calls (#8199)

modify section context when parsing functions

* add runtime error when EffSort aborts due to null values.

* catch runtime errors
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@sovdeeth @erenkarakal
Runtime error for when EffSort aborts due to null value (SkriptLang#8206
53f0d8c 
)

* Swap reset and delete errors in EffChange (SkriptLang#8177)

swap reset and delete errors

* Fix improper grammar in update block syntax (SkriptLang#8072)

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Fix Incorrect Variable Change Queue Processing (SkriptLang#8182)

Fix incorrect change processing order

* Change registerExpression() parameter name (SkriptLang#8180)

change parameter name

* Move EvtRealTime to main thread (SkriptLang#8185)

* Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189)

Account for functions with all optional parameters

* Properly parse exprsecs in function calls (SkriptLang#8199)

modify section context when parsing functions

* add runtime error when EffSort aborts due to null values.

* catch runtime errors
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@sovdeeth @erenkarakal
Runtime error for when EffSort aborts due to null value (SkriptLang#8206
12fa52b 
)

* Swap reset and delete errors in EffChange (SkriptLang#8177)

swap reset and delete errors

* Fix improper grammar in update block syntax (SkriptLang#8072)

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Fix Incorrect Variable Change Queue Processing (SkriptLang#8182)

Fix incorrect change processing order

* Change registerExpression() parameter name (SkriptLang#8180)

change parameter name

* Move EvtRealTime to main thread (SkriptLang#8185)

* Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189)

Account for functions with all optional parameters

* Properly parse exprsecs in function calls (SkriptLang#8199)

modify section context when parsing functions

* add runtime error when EffSort aborts due to null values.

* catch runtime errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@TheMug06 TheMug06 Awaiting requested review from TheMug06 TheMug06 is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
2.13 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erenkarakal @sovdeeth @APickledWalrus @Absolutionism