Skip to content

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Sep 1, 2025

Problem

When using a combination of ExprReversedList, a literal, and another expression that intakes the literal type, was causing incorrect parsing. Such as reversed 5 times
Since there were no checks if the expression being used in ExprReversedList was single, 5 was acceptable, and ExprReversedList#getReturnType uses the return type from the expression, in this case 5, it was then resulting in times being done afterwards
Parse result: (reversed 5) times

Solution

Simply checks if the expression is single in ExprReversedList and returns false if so.

Testing Completed

8170-reversed-single.sk

Supporting Information

N/A


Completes: #8170
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner September 1, 2025 20:26
@Absolutionism Absolutionism requested review from Burbulinis and erenkarakal and removed request for a team September 1, 2025 20:26
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Sep 1, 2025
@Absolutionism Absolutionism added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed needs reviews A PR that needs additional reviews labels Sep 1, 2025
@Absolutionism Absolutionism linked an issue Sep 1, 2025 that may be closed by this pull request
1 task
@Absolutionism Absolutionism moved this to In Review in 2.12 Releases Sep 1, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Sep 1, 2025
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 1, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Sep 1, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Sep 1, 2025
@sovdeeth sovdeeth merged commit bedf21c into SkriptLang:dev/patch Sep 1, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.12 Releases Sep 1, 2025
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 1, 2025
@Absolutionism Absolutionism moved this from Done - Awaiting Release to Done - Released in 2.12 Releases Sep 2, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Update 8170-reversed-single.sk
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Update 8170-reversed-single.sk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

"reversed X times" is broken

3 participants