Adds an ARGB method to the Color API #8120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested review from
Absolutionism and
Pesekjak
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
EquipableMC
suggested changes
Aug 10, 2025
Contributor
EquipableMC
left a comment
EquipableMC
left a comment
There was a problem hiding this comment.
Where is the check regarding if ARGB is even supported? Not all versions have this, and this will throw a NoClassDefFoundError exception.
Contributor
Author
It's existed before Skript's supported MC version 1.19.4 |
Efnilite
approved these changes
Aug 10, 2025
Burbulinis
approved these changes
Aug 10, 2025
skriptlang-automation
bot
added
feature-ready
Efnilite
added
the
enhancement
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Absolutionism
approved these changes
Aug 11, 2025
Pesekjak
approved these changes
Aug 11, 2025
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
added
completed
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Adds an ARGB method to color api * Update src/main/java/ch/njol/skript/util/Color.java
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Adds an ARGB method to color api * Update src/main/java/ch/njol/skript/util/Color.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Minecraft internally in NMS uses ARGB frequently. Skript base Color class doesn't have a quick method for getting the ARGB of a color without being a SkriptColor
Solution
Adds a method to allow overriding ARGB in your custom implementation Color class.
Completes: none
Related: none