Fix loss of converter info with ExprLoopValue #8109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
Absolutionism and
erenkarakal
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
1 task
Efnilite
approved these changes
Aug 2, 2025
Absolutionism
approved these changes
Aug 3, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
patch-ready
UnderscoreTud
approved these changes
Aug 3, 2025
APickledWalrus
approved these changes
Aug 7, 2025
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.12 Releases
skriptlang-automation
bot
removed
the
patch-ready
Absolutionism
moved this from Done - Awaiting Release
to Done - Released
in 2.12 Releases
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In specific cases,
loop-valuefailed to convert to the expected type due to a loss of converter info that lead to simplification ultimately determining that it only needed an Object -> Object converter, which is effectivelyreturn this. This lead to issues like #8108 where the name of loop-value could not be determined due to an ItemStack being returned, which is not AnyNamed, rather than the ItemStack being converted to AnyNamed via ItemType.Solution
The problem stemmed from ExprLoopValue#getConvertedExpression, which had a special implementation that at one point was probably useful? It effectively just made a dynamic converter using Converters.convert to attempt each possible to type in order.
Sharp-eyed viewers may note this as being what ConvertedExpression#newInstance does during init, so really it's just a runtime call to CE#newInstance, if we're matching high level behavior. However, it results in a CE that thinks it's just a simple Object->Object converter and doesn't actually know what it's supposed to be doing, leading to the loss of info mentioned previously.
Replacing this special converter with CE#newInstance results in the expected ConvertedExpression being formed, with CInfos to each of the possible return types, and all the necessary information retained. This also makes the condition in ELV#gCE() useless, since the super impl is just CE#newInstance, so the whole method can be and was removed.
Testing Completed
Added a new regression test based on the code provided in #8108.
Supporting Information
Completes: #8108
Related: none