Update EffVisualEffect syntax to also include entities on the number syntax #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested review from
cheeezburga and
erenkarakal
and removed request for
a team
APickledWalrus
approved these changes
Jul 24, 2025
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
Seems fine to me but would like to hear from @sovdeeth
APickledWalrus
added
enhancement
sovdeeth
approved these changes
Jul 26, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
probably was just forgotten at some point
skriptlang-automation
bot
added
the
patch-ready
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.12 Releases
skriptlang-automation
bot
added
completed
Absolutionism
moved this from Done - Awaiting Release
to Done - Released
in 2.12 Releases
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
missing the entities in the other part of the syntax
Solution
add it
Supporting Information
wondering if there was a conflict or something as to why this wasn't added, or maybe it was just missed?