Skip to content

Conversation

@TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 21, 2025

Problem

minecart maps to the Minecart.class which is an interface... You can't spawn an interface.

Solution

Update the MinecartData class with proper handling of the different Minecart classes.

I also moved the WORLD_1_17_CONSUMER outside the try catch, because it doesn't need to be doing a try catch every time an entity is spawned.

All of these would fail prior to this pull request aside from the spawning of a storage minecart:

spawn a minecart at player # spawns RidableMinecart
if last spawned minecart is a storage minecart: #false
if last spawned minecart is a minecart: #true
if last spawned minecart is a regular minecart: #true
spawn a storage minecart at player # spawns StorageMinecart
if last spawned minecart is a storage minecart: #true
if last spawned minecart is a minecart: #true
if last spawned minecart is a regular minecart: #false

Completes: #7663

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 21, 2025 07:40
@TheLimeGlass TheLimeGlass requested review from cheeezburga and erenkarakal and removed request for a team July 21, 2025 07:40
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 21, 2025
Copy link
Contributor

@Pesekjak Pesekjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Pesekjak Pesekjak added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 21, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 21, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 22, 2025
TheLimeGlass and others added 2 commits July 22, 2025 11:02
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
@APickledWalrus APickledWalrus linked an issue Jul 24, 2025 that may be closed by this pull request
1 task
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about ready

@APickledWalrus APickledWalrus moved this to In Review in 2.12 Releases Jul 24, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 29, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 30, 2025
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left new reply above on previous review comment

@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 30, 2025
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sovdeeth sovdeeth removed this from 2.12 Releases Sep 8, 2025
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Sep 8, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Sep 30, 2025
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Oct 1, 2025
@sovdeeth sovdeeth merged commit 316e574 into SkriptLang:dev/patch Oct 1, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Oct 1, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Oct 1, 2025
@TheLimeGlass TheLimeGlass deleted the fix/minecarts branch October 2, 2025 08:10
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

6 participants