-
-
Notifications
You must be signed in to change notification settings - Fork 416
Fixes and update Minecarts #8064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pesekjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
APickledWalrus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just about ready
APickledWalrus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left new reply above on previous review comment
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
cheeezburga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Problem
minecartmaps to the Minecart.class which is an interface... You can't spawn an interface.Solution
Update the MinecartData class with proper handling of the different Minecart classes.
I also moved the
WORLD_1_17_CONSUMERoutside the try catch, because it doesn't need to be doing a try catch every time an entity is spawned.All of these would fail prior to this pull request aside from the spawning of a storage minecart:
Completes: #7663