Make the temporary getRegistryClassInfo public and outside the BukkitClasses #8041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested review from
Burbulinis and
TheMug06
and removed request for
a team
sovdeeth
added
enhancement
Absolutionism
approved these changes
Jul 16, 2025
APickledWalrus
approved these changes
Jul 17, 2025
skriptlang-automation
bot
added
patch-ready
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
sovdeeth
approved these changes
Aug 1, 2025
Efnilite
approved these changes
Aug 1, 2025
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.12 Releases
skriptlang-automation
bot
added
completed
Absolutionism
moved this from Done - Awaiting Release
to Done - Released
in 2.12 Releases
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
…Classes (SkriptLang#8041) * Make the temporary getRegistryClassInfo public and outside the BukkitClasses * Update src/main/java/ch/njol/skript/bukkitutil/BukkitUtils.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
…Classes (SkriptLang#8041) * Make the temporary getRegistryClassInfo public and outside the BukkitClasses * Update src/main/java/ch/njol/skript/bukkitutil/BukkitUtils.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If this temporary solution of doing reflection is how Skript is going to registries for past version support, you need to also allow addon developers to do the same methods.
Also this new method being at the bottom of BukkitClasses will be a git conflict nightmare.
Solution
To move it into BukkitUtils or PaperUtils where this method calls parts of from anyways.
Other
This PR was made during the merge of 2.12 so when the dev/patch eventually gets updated from master, the target branch can be changed to that, assuming nothing gets reverted from master. Targeting dev/patch because this new way of registering registries needs to be given to addon developers asap.