-
-
Notifications
You must be signed in to change notification settings - Fork 414
Function overloading fixes and improvements #8032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
approved these changes
Jul 15, 2025
src/main/java/ch/njol/skript/lang/function/FunctionReference.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Jul 15, 2025
TheMug06
approved these changes
Jul 15, 2025
APickledWalrus
approved these changes
Jul 15, 2025
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 29, 2025
* init * fix single list value functions, clamp * fix dynamic functions * update docs * reviews * skript parser strikes again * enjoy your holiday pickle * fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.12
Targeting a 2.12.X version release. Project ID: 7
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
completed
The issue has been fully resolved and the change will be in the next Skript update.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getFunctionorgetSignaturewould match any function with the specified name. Now, passing no parameters will only match functions that also have no parameters.clampto exist. Now, instead of matching any function with the same name, the arguments are actually checkedSolution
candidatesto avoid returning any function when zero args are provided in theprovidedFunctionIdentifier.candidates, so functions likemeanactually get matched on argument types. Second, for functions likeclamp(1, 2, 3), adds a check to allow1to pass as a list. Third, removes outdated code from SkriptParser for parsing single list value params.Testing Completed
Supporting Information
Updates the test for StructFunction with local type hints as this part is now handled by FunctionReference.
Completes: #8030, #8031
Related: none