Skip to content

PigData HotFix #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

PigData HotFix #8012

merged 1 commit into from
Jul 8, 2025

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Jul 7, 2025

Problem

The SaddleState enum in PigData wasn't serializable or registered as so, causing a NotSerializableException when setting a pig entity data to a global variable.

Solution

Removes SaddleState in favor of Kleenean

Testing Completed

set {pig} to a pig
set {pig} to a saddled pig
set {pig} to an unsaddled pig

Supporting Information

N/A

Completes: none
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner July 7, 2025 23:03
@Absolutionism Absolutionism requested review from Burbulinis and TheMug06 and removed request for a team July 7, 2025 23:03
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 7, 2025
@Absolutionism Absolutionism added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 7, 2025
TheMug06
TheMug06 approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@TheMug06 TheMug06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jul 7, 2025
@Absolutionism Absolutionism moved this to In Review in 2.12 Releases Jul 8, 2025
@Absolutionism Absolutionism moved this from In Review to Awaiting Merge in 2.12 Releases Jul 8, 2025
@APickledWalrus APickledWalrus merged commit 29a47dd into SkriptLang:dev/feature Jul 8, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 8, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jul 8, 2025
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 8, 2025
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Jul 9, 2025
@Absolutionism @Burbulinis
PigData HotFix (SkriptLang#8012)
6cf3360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@TheMug06 TheMug06 TheMug06 approved these changes

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Absolutionism @APickledWalrus @TheMug06