Implement default simplify() on Expression #8001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
sovdeeth
requested review from
TheMug06 and
UnderscoreTud
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
APickledWalrus
approved these changes
Jul 3, 2025
Absolutionism
approved these changes
Jul 3, 2025
Burbulinis
approved these changes
Jul 3, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
feature-ready
skriptlang-automation
bot
added
completed
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
Update Expression.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Addons that directly implement Expression had to be recompiled since
simplify()moved from Expression to the Simplifiable interface.Solution
Providing a default implementation of simplify() removes the need to recompile.
Testing Completed
Supporting Information
Developers should keep in mind that implementing simplify is still highly recommended if possible, since leaving it to the default impl means no simplification can be done.
Completes: SkriptLang/skript-reflect#141
Related: none