-
-
Notifications
You must be signed in to change notification settings - Fork 416
Add case sensitivity support to ExprIndicesOf & Cleanup #7997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
APickledWalrus
merged 9 commits into
SkriptLang:dev/feature
from
Burbulinis:patch/fix-case-sensitivity
Jul 8, 2025
Merged
Add case sensitivity support to ExprIndicesOf & Cleanup #7997
APickledWalrus
merged 9 commits into
SkriptLang:dev/feature
from
Burbulinis:patch/fix-case-sensitivity
Jul 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Jul 3, 2025
sovdeeth
approved these changes
Jul 3, 2025
Efnilite
requested changes
Jul 3, 2025
Member
Efnilite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice
Efnilite
approved these changes
Jul 3, 2025
Member
Author
|
I have also renamed the expression from |
APickledWalrus
approved these changes
Jul 8, 2025
Burbulinis
added a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the
indices ofexpression always performs case-sensitive string comparisons, without the ability to do otherwise.Solution
This PR updates the behaviour so that string comparisons now follow the
case sensitiveoption defined in Skript's configuration. As well, it updates usage of the old@Examplesannotation to@Exampleand adds utility methods toStringUtils.Testing Completed
I don't believe there is a good way to test this. Manual testing has confirmed this works properly.
Supporting Information
Prior to the updates to this expression,
index of string in stringalways used case-sensitive comparisons, so existing scripts that relied on that behaviour may now break if thecase sensitivenode isfalsein the configuration.Completes: none
Related: none