Prevent exceptions when using experimental syntax in effect commands #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
APickledWalrus
requested review from
TheMug06 and
UnderscoreTud
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
approved these changes
Jul 3, 2025
erenkarakal
approved these changes
Jul 3, 2025
skriptlang-automation
bot
added
the
feature-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
removed
the
needs reviews
UnderscoreTud
approved these changes
Jul 3, 2025
skriptlang-automation
bot
added
the
completed
skriptlang-automation
bot
removed
the
feature-ready
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, you will face an exception when attempting to use experimental syntax in effect commands:
Solution
The solution, for now, is to simply return an empty ExperimentSet if the ParserInstance is inactive. In the future, we will consider methods for using experimental syntax in effect commands, but that is out of scope for this PR/2.12
Testing Completed
Manual testing confirms the issue is resolved:
Supporting Information
n/a
Completes: none
Related: none