Enforce main thread when changing variables during structure loading #7964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
UnderscoreTud
approved these changes
Jun 22, 2025
APickledWalrus
approved these changes
Jun 24, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
patch-ready
skriptlang-automation
bot
added
the
completed
skriptlang-automation
bot
removed
the
patch-ready
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#7963 Variables were attempting to be set asynchronously when using the async script loader setting.
Solution
Changes StructParse and StructVariables to enforce using the main thread when changing variables.
Testing Completed
Manual testing with the existing test scripts and the async loader enabled.
Supporting Information
This is very much a bandaid and not a comprehensive fix of async loading. There are no doubt many more issues with it.
Completes: #7963
Related: none