Skip to content

Paper 1.21.6 Update #7957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Paper 1.21.6 Update #7957

merged 1 commit into from
Jun 19, 2025

Conversation

@Absolutionism
Copy link
Contributor

Problem

N/A

Solution

Updates build.gradle and gradle.properties by changing 1.21.5 -> 1.21.6
Adds paper-1.21.6.json for the testing environment
Updates default.lang for new entries in enums/registries

Testing Completed

N/A

Supporting Information

N/A

Completes: none
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner June 17, 2025 15:14
@Absolutionism Absolutionism requested review from Efnilite and UnderscoreTud and removed request for a team June 17, 2025 15:14
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 17, 2025
@Absolutionism Absolutionism added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Jun 17, 2025
APickledWalrus
APickledWalrus approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should remove the 1.21.3 environment (possibly .4 too)

@Absolutionism
Copy link
Contributor Author

maybe we should remove the 1.21.3 environment (possibly .4 too)

Shane had mentioned removing some environments in the PR for updating to 1.21.5 and Sovde said:

Since we have between a third and a half of our users running 1.20.0/1/2/3/4/5 and 1.21.0/1/3, I think it's worth keeping them to see if we break anything. We're not obligated to fix it, but it's often worth fixing regardless and I'd like to have the warning the tests provide.
We may want to consider dropping 1.19.4 for 2.12, though.

@APickledWalrus
Copy link
Member

1.21.3 is only a couple hundred servers / few percent, but I'm fine keeping it for now

@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Jun 17, 2025
@sovdeeth sovdeeth merged commit c1c24f0 into SkriptLang:dev/patch Jun 19, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Jun 19, 2025
@sovdeeth sovdeeth moved this to Done in 2.12 Releases Jun 19, 2025
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Jul 9, 2025
@Absolutionism @Burbulinis
Paper 1.21.6 Update (SkriptLang#7957)
d15db04 
Initial Commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Absolutionism @APickledWalrus @sovdeeth @Efnilite