-
-
Notifications
You must be signed in to change notification settings - Fork 415
Scientific notation #7933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scientific notation #7933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sovdeeth
approved these changes
Jun 8, 2025
Burbulinis
approved these changes
Jun 9, 2025
…o feature/scientific-notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
completed
The issue has been fully resolved and the change will be in the next Skript update.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Scientific notation is a way of easily representing large numbers, such as
1.23e+9representing1 230 000 000. Most major languages have support for representing numbers like this, but Skript doesn't :(Solution
Updates the existing regex for integer and rational numbers to include allowing the use of the format
X[eE][+-]Y. No implementation changes were necessary, as the existing methods allow this change to pass the tests.Testing Completed
scientific notation.sktest added, manually confirmed to be working.Supporting Information
Completes: #4553
Related: none