Fix EffSort clobbering duplicate inputs #7928
Merged
+21
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
Burbulinis and
TheMug06
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
1 task
Efnilite
approved these changes
Jun 7, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
patch-ready
Burbulinis
approved these changes
Jun 9, 2025
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
Fix duplicate clobbering by moving away from a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #7926. Sorting a list with 2 of the same value would result in a sorted list with only 1 of that value instead of 2.
Solution
This was due to using a map to tie current and mapped values, which only allowed a single current value. The solution was to move to a List of paired values, which allows as many duplicated as desired.
Testing Completed
Added a regression test.
Supporting Information
Completes: #7926
Related: none