Skip to content

PropertyCondition#getExpr #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

PropertyCondition#getExpr #7927

merged 3 commits into from
Jun 9, 2025

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Jun 6, 2025

Problem

Elements that extend PropertyCondition and override toString needed to override init to be able to get the expression for the toString

Solution

Adds #getExpr removing the need for overriding init to gain access to the expression.

Testing Completed

N/A

Supporting Information

N/A

Completes: none
Related: none

@Absolutionism Absolutionism requested review from a team as code owners June 6, 2025 20:55
@Absolutionism Absolutionism requested review from Burbulinis and UnderscoreTud and removed request for a team June 6, 2025 20:55
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 6, 2025
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 6, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Releases Jun 6, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Jun 6, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jun 6, 2025
@Burbulinis Burbulinis merged commit ad9a8e8 into SkriptLang:dev/feature Jun 9, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@Burbulinis Burbulinis Burbulinis approved these changes

@TheMug06 TheMug06 TheMug06 approved these changes

Assignees

No one assigned

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Absolutionism @sovdeeth @APickledWalrus @UnderscoreTud @Burbulinis @TheMug06