Skip to content

Fix: Remove duplicate 'bad omen' alias from raid_omen potion effect #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2025

Conversation

LalitNarayanYadav
Copy link
Contributor

@LalitNarayanYadav LalitNarayanYadav commented Jun 4, 2025

Problem

The all potion effect types list currently includes "bad omen" twice and does not correctly distinguish between "bad omen" and the newer "raid omen" effect. This happens because raid_omen is aliased as both "bad omen" and "raid omen" in default.lang. As a result, scripts referencing potion effects may encounter duplicate or unintended entries.

Solution

This pull request updates the default.lang file to remove "bad omen" as an alias for raid_omen. With this change, raid_omen will only respond to "raid omen", preventing duplication and aligning the aliases more accurately with Minecraft version 1.21+ behavior.

Testing Completed

  • Used a test Skript command:
    command /test:
        trigger:
            set {_effects::*} to all potion effect types
            loop {_effects::*}:
                if loop-value is bad omen or raid omen:
                    add loop-value to {_output::*}
            send "%{_output::*}%"
    
    

Completes: #7916

Related: none

@LalitNarayanYadav LalitNarayanYadav requested a review from a team as a code owner June 4, 2025 18:57
@LalitNarayanYadav LalitNarayanYadav requested review from Burbulinis and TheMug06 and removed request for a team June 4, 2025 18:57
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 4, 2025
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 4, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jun 4, 2025
@Efnilite Efnilite changed the base branch from master to dev/feature June 4, 2025 19:53
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 4, 2025
@sovdeeth sovdeeth moved this to Awaiting Merge in 2.12 Releases Jun 6, 2025
@sovdeeth sovdeeth merged commit 475b133 into SkriptLang:dev/feature Jun 7, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
Status: Done - Released
Development

Successfully merging this pull request may close these issues.

'all potion effect types' includes Bad Omen twice, and doesn't include Raid Omen
7 participants