Skip to content

EntityData Event Value #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev/feature
Choose a base branch
from

Conversation

Absolutionism
Copy link
Contributor

Problem

Skript did not have an event value to grab the entity type (EntityData) of an entity for EntityEvent

Solution

Registers a new event value for EntityEvent to get the entity type (EntityData) with event restrictions.

Testing Completed

on spawn:
  broadcast event-entity type

Supporting Information

N/A


Completes: #7818
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 30, 2025 21:35
@Absolutionism Absolutionism requested review from Efnilite and UnderscoreTud and removed request for a team May 30, 2025 21:35
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 30, 2025
@sovdeeth
Copy link
Member

sovdeeth commented May 30, 2025

What's the point of this? You can just do type of event-entity, no?

edit: I just read the attached issue and default values are mentioned, which makes sense. Otherwise i wouldn't really see a point in going from event-entity's type to event-entity type

@Fusezion
Copy link
Contributor

Utltity? Unsure what else you want said.

@Absolutionism
Copy link
Contributor Author

edit: I just read the attached issue and default values are mentioned, which makes sense. Otherwise i wouldn't really see a point in going from event-entity's type to event-entity type

Sooo review approval?

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels May 30, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Release Jun 3, 2025
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
Status: Awaiting Merge
Development

Successfully merging this pull request may close these issues.

4 participants