Timezone Support #7887
Open
Timezone Support #7887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
Efnilite and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
requested changes
May 22, 2025
sovdeeth
added
the
enhancement
ShaneBeee
reviewed
May 22, 2025
Absolutionism
suggested changes
May 22, 2025
| if (usingTimezone) { | ||
| String timezone = this.timezone.getSingle(event); | ||
| if (timezone == null) { | ||
| return new Date[0]; |
There was a problem hiding this comment.
Should probably throw a runtime error here
| try { | ||
| targetZoneId = ZoneId.of(timezone); | ||
| } catch (DateTimeException e) { // invalid zone format | ||
| return new Date[0]; |
There was a problem hiding this comment.
I don't know about throwing an error here, there is no way to check if the timezone is valid
So the user can't sanitize it even if they wanted to
There was a problem hiding this comment.
Could add a condition to check if the timezone is a valid one
There was a problem hiding this comment.
is a lookup on 603 time zones worth it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There isn't a way to get the date in a timezone without knowing its time offset.
Solution
Adds a new pattern to the
nowexpression that lets you get the current clock time in the specified timezone. It won't be equal tonowas it returns the shifted time (which will be mentioned in the syntax descriptions later).Also adds a new expression for getting a list of valid time zones.
Syntaxes:
now [timezone:in time[ ]zone %-string%]all time[ ]zonesTesting Completed
Only manual testing was done. Proper tests will be written after syntax/functionality reviews.
Supporting Information
Completes: none
Related: none