Skip to content

Pig Variants #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 15, 2025
Merged

Pig Variants #7846

merged 7 commits into from
May 15, 2025

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented May 1, 2025

Description

This PR aims to add support for Pig Variants.
By doing so, this PR adds:

  • BukkitClasses#getRegistryClassInfo : Which checks if the variant class exists and is present within either Bukkit's or Paper's Registry. Then proceeds to return a RegistryClassInfo if found or a filler/dummy ClassInfo
  • PaperUtils : Utils class for Paper related stuff
    • #registryExists : Same as BukkitUtils#registryExists but checks in Paper's Registry
    • #getBukkitRegistry : Gets the Bukkit Registry version of a Paper Registry

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 1, 2025 21:28
@Absolutionism Absolutionism requested review from Efnilite and sovdeeth and removed request for a team May 1, 2025 21:28
sovdeeth
sovdeeth requested changes May 1, 2025
View reviewed changes
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label May 1, 2025
@Absolutionism Absolutionism requested a review from sovdeeth May 2, 2025 02:42
sovdeeth
sovdeeth requested changes May 5, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some debug/testmode warnings when registries aren't found
Specifically when reflection fails, rather than classes not existing.

@Absolutionism Absolutionism requested a review from sovdeeth May 5, 2025 01:13
sovdeeth
sovdeeth approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 6, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Releases May 14, 2025
sovdeeth
sovdeeth requested changes May 14, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this, i'm testing the bot

@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 14, 2025
sovdeeth
sovdeeth requested changes May 14, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore

@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels May 14, 2025
@sovdeeth sovdeeth marked this pull request as draft May 14, 2025 22:57
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 14, 2025
@sovdeeth sovdeeth marked this pull request as ready for review May 14, 2025 22:57
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 14, 2025
@sovdeeth sovdeeth merged commit 85beea7 into SkriptLang:dev/feature May 15, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2.12 Releases May 15, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. completed The issue has been fully resolved and the change will be in the next Skript update. labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

Assignees

No one assigned

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Absolutionism @sovdeeth @Efnilite