Skip to content

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to add panda support by:

  • Check if a panda is eating, with an effect (including horse types)
  • Check if a panda is rolling, with an effect
  • Check if a panda is scared
  • Check if a panda is sneezing, with an effect
  • Check if a panda is on its back, with an effect
  • Expression for the main and hidden genes of a panda, with a changer

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner March 25, 2025 04:12
@Absolutionism Absolutionism requested review from APickledWalrus and UnderscoreTud and removed request for a team March 25, 2025 04:12
@Absolutionism Absolutionism changed the title Initial Commit Panda Support Mar 25, 2025
@Efnilite Efnilite added the feature Pull request adding a new feature. label Mar 25, 2025
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't Gene be registered as a type?

@Fusezion
Copy link
Contributor

Fusezion commented Mar 25, 2025

shouldn't Gene be registered as a type?

Already was for it's entity data

if (Skript.classExists("org.bukkit.entity.Panda$Gene")) {
Classes.registerClass(new EnumClassInfo<>(Gene.class, "gene", "genes")
.user("(panda )?genes?")
.name("Gene")
.description("Represents a Panda's main or hidden gene. " +
"See <a href='https://minecraft.wiki/w/Panda#Genetics'>genetics</a> for more info.")
.since("2.4")
.requiredPlugins("Minecraft 1.14 or newer"));
}

@Absolutionism
Copy link
Contributor Author

shouldn't Gene be registered as a type?

If it wasn't, the ExprPandaGene test would've failed.

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff 🙂 a few minor things

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to make the start/stop parse tag changes (i.e. combining the patterns) for the other syntax classes? Apologies if I was unclear before.

@APickledWalrus APickledWalrus merged commit 5b082f4 into SkriptLang:dev/feature Apr 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants