Skip to content

ExprHash cleanup #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 3, 2025
Merged

ExprHash cleanup #7742

merged 11 commits into from
Jun 3, 2025

Conversation

OfficialDonut
Copy link
Contributor

Description

  • Don't recommend SHA for passwords in the documentation
  • Added SHA-384 and SHA-512
  • Added suppressible warning when MD5 is used
  • Added tests

Target Minecraft Versions: any
Requirements: none
Related Issues: #5836

@OfficialDonut OfficialDonut requested review from a team as code owners March 23, 2025 19:52
@OfficialDonut OfficialDonut requested review from APickledWalrus and UnderscoreTud and removed request for a team March 23, 2025 19:52
Fusezion
Fusezion suggested changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the core just yet, only what base line of things

Efnilite
Efnilite requested changes Mar 23, 2025
View reviewed changes
Fusezion
Fusezion suggested changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I got most things, but I could miss a few as efy said some more cleaning up could be done

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Mar 23, 2025
OfficialDonut and others added 2 commits March 23, 2025 16:05
@OfficialDonut @Fusezion
Apply suggestions from code review
5d5078d 
Co-authored-by: Fusezion <fusezionstream@gmail.com>
@OfficialDonut
Changes from review
b01caf2
Efnilite
Efnilite requested changes Mar 23, 2025
View reviewed changes
OfficialDonut and others added 2 commits March 23, 2025 16:28
@OfficialDonut @Efnilite
Update src/main/java/ch/njol/skript/expressions/ExprHash.java
43a1624 
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
@OfficialDonut
Changes from review
ec16d4d
erenkarakal
erenkarakal reviewed Mar 23, 2025
View reviewed changes
Absolutionism
Absolutionism approved these changes Mar 23, 2025
View reviewed changes
@OfficialDonut @Absolutionism
Apply suggestions from code review
bf6a47d 
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
APickledWalrus
APickledWalrus requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I found. Thanks for your work so far!

@Efnilite Efnilite requested a review from APickledWalrus April 29, 2025 08:28
APickledWalrus
APickledWalrus approved these changes Apr 30, 2025
View reviewed changes
OfficialDonut and others added 2 commits April 30, 2025 23:16
@OfficialDonut @APickledWalrus
Update src/main/java/ch/njol/skript/expressions/ExprHash.java
be55c69 
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@OfficialDonut
Fix compile
d0fec56
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 14, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Release May 14, 2025
@sovdeeth sovdeeth merged commit cbe81ea into SkriptLang:dev/feature Jun 3, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2.12 Release Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@erenkarakal erenkarakal erenkarakal approved these changes

@Fusezion Fusezion Fusezion approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
2.12 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@OfficialDonut @APickledWalrus @Efnilite @erenkarakal @Fusezion @Absolutionism @sovdeeth