Skip to content

Conversation

sovdeeth
Copy link
Member

Description

Fixes an ArrayStoreException in ExprArray when integers are input. The array from getArray can be a Integer[] array and does not accept Doubles. (the ide doesn't catch this because the variable is a Number[] array).


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Mar 16, 2025
@sovdeeth sovdeeth requested a review from Efnilite March 16, 2025 19:53
@sovdeeth sovdeeth changed the base branch from master to dev/patch March 16, 2025 19:55
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not know this was a thing mb

@sovdeeth sovdeeth requested a review from a team March 17, 2025 05:50
@APickledWalrus APickledWalrus requested review from a team, Romitou and Pesekjak and removed request for a team March 17, 2025 17:04
@Efnilite Efnilite added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Mar 19, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner March 19, 2025 19:26
@sovdeeth sovdeeth requested a review from UnderscoreTud March 19, 2025 19:26
@sovdeeth sovdeeth merged commit 4a28bac into SkriptLang:dev/patch Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants